Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change API to allow lazy load DB connections #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change API to allow lazy load DB connections #20

wants to merge 1 commit into from

Conversation

esler
Copy link
Contributor

@esler esler commented Jan 13, 2021

No description provided.

@esler esler requested a review from kambo-1st January 13, 2021 08:40
@esler
Copy link
Contributor Author

esler commented Jan 13, 2021

there's a problem

$ phpunit --stop-on-fail
PHPUnit 9.3.7 by Sebastian Bergmann and contributors.

E

Time: 00:00.080, Memory: 6.00 MB

There was 1 error:

1) IW\PHPUnit\DbFixtures\UsageOfDbFixturesTraitTest::testBds with data set "mysql" (PDO Object ())
PDOException: There is no active transaction

/Users/esler/iw/intraworlds/phpunit-db-fixtures/src/DbFixturesTrait.php:288
/Users/esler/iw/intraworlds/phpunit-db-fixtures/src/DbFixturesTrait.php:209
/Users/esler/iw/intraworlds/phpunit-db-fixtures/src/DbFixturesTrait.php:86
/Users/esler/iw/intraworlds/phpunit-db-fixtures/src/DbFixturesTrait.php:74

Table cleanup (TRUNCATE TABLE) will cause implicit commit. Any suggestions?

@esler esler force-pushed the lazy-load-connections branch 3 times, most recently from e0a1d20 to 6b0a7fc Compare January 13, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kambo-1st kambo-1st Awaiting requested review from kambo-1st

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esler