LQT: adjust budget every block #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
added
the
consensus-breaking
erwanor
reviewed
Feb 12, 2025
| .get_distributions_params() | ||
| .await | ||
| .expect("distribution parameters should be available") | ||
| .staking_issuance_per_block as u128; | ||
| .liquidity_tournament_incentive_per_block |
erwanor
approved these changes
Feb 12, 2025
conorsch
pushed a commit
that referenced
this pull request
Feb 14, 2025
## Describe your changes This adjusts the issuance budget every block, incrementing it by the issuance per block, every block, rather than clobbering the current value with `issuance_per_block * how_long_the_epoch_was` at the end of an epoch. This has the effects of: - making the value always match that claimed by the events, simplifying indexing, - seamlessly rolling over un-issued rewards to the next epoch, - simplifying the code. I also pushed a small change to use a proper Event struct. Testing deferred. ## Issue ticket number and link ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > This breaks consensus, but I think this can be applied to the testnet just by pushing the change to the majority validator, which will then issue the incorrect reward amount for exactly one epoch. This has no bearing on any eventual mainnet upgrade. We could avoid this by using a second state key, but putting in this scar tissue seems more performative than actually valuable, given that the upgrade isn't in a final state yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This adjusts the issuance budget every block, incrementing it by the issuance per block, every block, rather than clobbering the current value with
issuance_per_block * how_long_the_epoch_wasat the end of an epoch. This has the effects of:I also pushed a small change to use a proper Event struct.
Testing deferred.
Issue ticket number and link
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: