LQT: fix start position <=> epoch comparison #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows planners to correctly use the first position in the epoch. This works because the ZK proof verifies that the start position is strictly less. c.f. https://github.com/penumbra-zone/penumbra/blob/7869803be0b844f09c8c5efeeaa92384b8a6ba35/crates/core/component/governance/src/delegator_vote/proof.rs#L234
cronokirby
added
the
consensus-breaking
|
Maybe we should just restrict the check to be for (e, 0, 0) specifically, since that's the only thing I expect planners to produce |
erwanor
approved these changes
Feb 7, 2025
crates/core/component/funding/src/action_handler/liquidity_tournament/mod.rs
Show resolved
Hide resolved
conorsch
pushed a commit
that referenced
this pull request
Feb 14, 2025
## Describe your changes lqt: fix epoch <=> start position comparison This allows planners to correctly use the first position in the epoch. This works because the ZK proof verifies that the start position is strictly less. c.f. https://github.com/penumbra-zone/penumbra/blob/7869803be0b844f09c8c5efeeaa92384b8a6ba35/crates/core/component/governance/src/delegator_vote/proof.rs#L234 Testing deferred. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
lqt: fix epoch <=> start position comparison
This allows planners to correctly use the first position in the epoch.
This works because the ZK proof verifies that the start position is strictly less.
c.f.
penumbra/crates/core/component/governance/src/delegator_vote/proof.rs
Line 234 in 7869803
Testing deferred.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: