-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pindexer: add dex block summary #5063
base: main
Are you sure you want to change the base?
Conversation
@JasonMHasperhoven and I paired a bit to debug the failing smoke test. To investigate, I pulled down this branch, ran That error, in text, is:
Clear enough: we've got to massage the types a bit. Typically we use JSON blobs to store Penumbra types in postgres via pindexer, but as the spec in penumbra-zone/dex-explorer#338 indicates, we don't want to do that here. Instead, we want a full custom type inside the db. I took a stab at implementing
Subsequent work should pick up from there. Take the Encode impl with a grain of salt, @JasonMHasperhoven , because this code isn't actually working yet! But hopefully this is one step closer. |
-- Primary key | ||
rowid SERIAL PRIMARY KEY, | ||
-- The height of the block. | ||
height INTEGER NOT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cronokirby noticed that some inserts fail if we are adding a UNIQUE
constraint on height, but my understanding is that this part of the pipeline should have exactly once semantics on delivery. is that right?
wondering if this is caused by the catchup logic: https://github.com/penumbra-zone/penumbra/blob/erwan/pindexer_block_summary/crates/util/cometindex/src/indexer/indexing_state.rs#L271 (<=
vs. <
). unsure.
AFAICT this is good to go, the integration test seems to timeout because of the commitment source addition. |
Describe your changes
WIP pairing
Issue ticket number and link
penumbra-zone/dex-explorer#338
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: