-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
governance: use concurrent build #5043
Conversation
) | ||
.await | ||
.expect( | ||
"community pool transactions are always well-formed and should never fail to build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? also general question, why is this logic embedded in the top-level action handler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can switch from .build()
to .build_concurrent()
without introducing an expect()
. Let's be cautious about introducing changes to how errors are handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sound, although I'm tagging in @erwanor for confirmation on consensus implications. My asks are:
- target the
protocol/lqt_support
feature branch, as described in Tracking issue: LQT #5010 - don't introduce an
expect
if we can avoid it
In the meantime I'm tagging this as consensus-breaking out of caution.
) | ||
.await | ||
.expect( | ||
"community pool transactions are always well-formed and should never fail to build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can switch from .build()
to .build_concurrent()
without introducing an expect()
. Let's be cautious about introducing changes to how errors are handled.
We typically use the serial build method in action handlers. I don't think we should change anything in the action handlers without a motivation why. It's an easy source of divergence. Here, it might make sense, but we have to be conservative and extremely deliberate with AHs, so closing for now so we can focus on other things. |
Describe your changes
uses concurrent build for governance proposals
Issue ticket number and link
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: