Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: use concurrent build #5043

Closed
wants to merge 1 commit into from
Closed

governance: use concurrent build #5043

wants to merge 1 commit into from

Conversation

TalDerei
Copy link
Collaborator

@TalDerei TalDerei commented Feb 2, 2025

Describe your changes

uses concurrent build for governance proposals

Issue ticket number and link

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

)
.await
.expect(
"community pool transactions are always well-formed and should never fail to build",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? also general question, why is this logic embedded in the top-level action handler?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can switch from .build() to .build_concurrent() without introducing an expect(). Let's be cautious about introducing changes to how errors are handled.

@TalDerei TalDerei changed the title community pool: use concurrent build governance: use concurrent build Feb 2, 2025
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound, although I'm tagging in @erwanor for confirmation on consensus implications. My asks are:

  1. target the protocol/lqt_support feature branch, as described in Tracking issue: LQT #5010
  2. don't introduce an expect if we can avoid it

In the meantime I'm tagging this as consensus-breaking out of caution.

)
.await
.expect(
"community pool transactions are always well-formed and should never fail to build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can switch from .build() to .build_concurrent() without introducing an expect(). Let's be cautious about introducing changes to how errors are handled.

@conorsch conorsch requested a review from erwanor February 3, 2025 22:58
@conorsch conorsch added the consensus-breaking breaking change to execution of on-chain data label Feb 3, 2025
@erwanor
Copy link
Member

erwanor commented Feb 4, 2025

We typically use the serial build method in action handlers. I don't think we should change anything in the action handlers without a motivation why. It's an easy source of divergence. Here, it might make sense, but we have to be conservative and extremely deliberate with AHs, so closing for now so we can focus on other things.

@erwanor erwanor closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-breaking breaking change to execution of on-chain data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants