Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make pair selector error visible and scrollable #217

Closed
wants to merge 2 commits into from
Closed

fix: make pair selector error visible and scrollable #217

wants to merge 2 commits into from

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Dec 14, 2024

fixes #201

makes pair selector error visible and scrollable

image

@vacekj vacekj linked an issue Dec 14, 2024 that may be closed by this pull request
Hidden error text displayed on screen #201
Open
@vacekj vacekj requested a review from a team December 14, 2024 00:11
@grod220
Copy link
Contributor

grod220 commented Dec 14, 2024

A few things:

  1. This doesn't quite feel in the spirit of the error state designs in figma
  2. @VanishMax has picked up Updated asset selector component #163 which updates this component entirely. Error states are likely handled differently there
  3. I actually made a mistake about moving that issue into the sprint board. I thought it was the error state that corresponded to the Summary component.

@vacekj
Copy link
Member Author

vacekj commented Dec 16, 2024

Closing in favour of #211

@vacekj vacekj closed this Dec 16, 2024
@vacekj vacekj deleted the 201-hidden-error-text-displayed-on-screen branch December 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hidden error text displayed on screen
3 participants
@vacekj @grod220 @TalDerei