Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new Vibe tokens based on style guide #850

Closed
wants to merge 2 commits into from
Closed

Conversation

rsalvucci
Copy link
Contributor

@rsalvucci rsalvucci commented May 29, 2024

Adding new Vibe tokens based on style guide

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented May 29, 2024

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-czv87xbgh-penske-media-corp.vercel.app

Built with commit accadc6.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

🚨 Backstop Visual Regression Tests Failed: View the results for 6ed73b60d378cfee4fdc34a57fa3fedbff2db67b.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

@bluecollarcoders bluecollarcoders self-requested a review May 30, 2024 18:42
Copy link
Contributor

🚨 Backstop Visual Regression Tests Failed: View the results for accadc6f3c7a391a53022594509e33edbc4100ad.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

@rsalvucci rsalvucci closed this May 30, 2024
@rsalvucci rsalvucci deleted the feature/BR-3394 branch May 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants