Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR-3030: Add pullquote memo prototype. #835

Merged
merged 3 commits into from
Jan 2, 2024
Merged

BR-3030: Add pullquote memo prototype. #835

merged 3 commits into from
Jan 2, 2024

Conversation

allan23
Copy link
Contributor

@allan23 allan23 commented Dec 19, 2023

This change adds the pullquote.memo prototype that is referenced by some brands.

Ticket: https://penskemedia.atlassian.net/browse/BR-3030

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-p9wz8682o-penske-media-corp.vercel.app

Built with commit 754d22c.
This pull request is being automatically deployed with vercel-action

@allan23 allan23 marked this pull request as ready for review January 2, 2024 19:21
@JordanPak JordanPak merged commit 7dd9ee3 into master Jan 2, 2024
3 checks passed
@JordanPak JordanPak deleted the feature/BR-3030 branch January 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants