Ready: monitor the funding account of vortex #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sharqiewicz
changed the title
|
@Sharqiewicz can you please merge or rebase the latest |
…-account-of-vortex
|
| Name | Status | Previous | Current |
|---|---|---|---|
@slack/logger |
- | 4.0.0 | |
@slack/types |
- | 2.14.0 | |
@slack/web-api |
- | 7.7.0 | |
@types/retry |
- | 0.12.0 | |
axios |
1.6.8 | 1.7.7 | |
is-electron |
- | 2.2.2 | |
p-retry |
- | 4.6.2 | |
retry |
0.12.0 | 0.13.1 | |
undici-types |
- | 6.19.8 |
ebma
reviewed
Nov 14, 2024
|
|
||
| // ensure we have at the very least 10 XLM in the account | ||
| if (Number(stellarBalance.balance) < STELLAR_FUNDING_AMOUNT_UNITS) { | ||
| slackNotifier.sendMessage({ | ||
| text: `Current balance of funding account is ${stellarBalance.balance} XLM please charge this account ${FUNDING_PUBLIC_KEY}.`, |
There was a problem hiding this comment.
Suggested change
| text: `Current balance of funding account is ${stellarBalance.balance} XLM please charge this account ${FUNDING_PUBLIC_KEY}.`, | |
| text: `Current balance of funding account is ${stellarBalance.balance} XLM, please charge the account ${FUNDING_PUBLIC_KEY}.`, |
Comment on lines
+146
to
+148
| text: `Current balance of funding account is ${divideByPowerOfTen( | ||
| nativeBalance, | ||
| ).toString()} PEN please charge this account ${fundingAccountKeypair.address}.`, |
There was a problem hiding this comment.
Suggested change
| text: `Current balance of funding account is ${divideByPowerOfTen( | |
| nativeBalance, | |
| ).toString()} PEN please charge this account ${fundingAccountKeypair.address}.`, | |
| text: `Current balance of funding account is ${divideByPowerOfTen( | |
| nativeBalance, | |
| ).toString()} PEN, please charge the account ${fundingAccountKeypair.address}.`, |
Comment on lines
+131
to
+133
| text: `Current balance of funding account is ${nativeToDecimal( | ||
| remainingMaxSubsidiesAvailable, | ||
| ).toString()} ${token} please charge this account ${fundingAccountKeypair.address}.`, |
There was a problem hiding this comment.
Suggested change
| text: `Current balance of funding account is ${nativeToDecimal( | |
| remainingMaxSubsidiesAvailable, | |
| ).toString()} ${token} please charge this account ${fundingAccountKeypair.address}.`, | |
| text: `Current balance of funding account is ${nativeToDecimal( | |
| remainingMaxSubsidiesAvailable, | |
| ).toString()} ${token}, please charge the account ${fundingAccountKeypair.address}.`, |
|
|
||
| if (balance < minimumBalance) { | ||
| slackService.sendMessage({ | ||
| text: `Current balance of funding account is ${balance} GLMR please charge this account ${moonbeamExecutorAccount.address}.`, |
There was a problem hiding this comment.
Suggested change
| text: `Current balance of funding account is ${balance} GLMR please charge this account ${moonbeamExecutorAccount.address}.`, | |
| text: `Current balance of funding account is ${balance} GLMR, please charge the account ${moonbeamExecutorAccount.address}.`, |
|
|
||
| if (balance < minimumBalance) { | ||
| slackService.sendMessage({ | ||
| text: `Current balance of funding account is ${balance} GLMR please charge this account ${moonbeamExecutorAccount.address}.`, |
There was a problem hiding this comment.
balance is the raw amount, not the unit amount, correct? In that case can we write
Suggested change
| text: `Current balance of funding account is ${balance} GLMR please charge this account ${moonbeamExecutorAccount.address}.`, | |
| text: `Current balance of funding account is ${balance.div(Big(10).pow(18)).toFixed(2,0)} GLMR please charge this account ${moonbeamExecutorAccount.address}.`, |
|
|
||
| slackNotifier.sendMessage({ | ||
| text: `Current balance of funding account is ${nativeToDecimal( | ||
| remainingMaxSubsidiesAvailable, |
There was a problem hiding this comment.
remainingMaxSubsidiesAvailable is actually not a currency amount but just a number counting how many subsidies are still possible with the remaining funds, assuming that every subsidy requires the maximum amount. Therefore nativeToDecimal does not make sense here.
Or you use tokenBalance instead of remainingMaxSubsidiesAvailable.
| if (nativeBalance.gte(minimumBalanceFundingAccount) && isTokensSufficient) { | ||
| return { status: true, public: fundingAccountKeypair.address }; | ||
| } | ||
| slackNotifier.sendMessage({ |
There was a problem hiding this comment.
It could be that we reach this point just because isTokensSufficient is false – in that case we already sent an error message above.
We only need to send this message if nativeBalance.gte(minimumBalanceFundingAccount).
Furthermore, don't forget the second argument apiData.decimals for divideByPowerOfTen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦈 🟢 PR
@slack/web-apiSLACK_WEB_HOOK_TOKENenv variablemoonbeam(GLMR),pendulum(EUR, USDC.axl, PEN),stellar(XLM)