Don't remove wallet account if storageAddress is undefined

[ebma]

I think this was caused by some kind of race condition that sometimes happens when switching the new tenant. I think it's fine to remove that call to fix the problem.

Closes #541.

[netlify]

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name	Link
🔨 Latest commit	86903ee
🔍 Latest deploy log	https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/67250647f0924e0008b4417b
😎 Deploy Preview	https://deploy-preview-595--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ebma]

@prayagd when testing the deploy preview, please also consider checking how the wallet connection behaves for wallet connect etc.

[prayagd]

Tested two different scenarios

• If i connect only to Pendulum network then the connection breaks when switching to other chains, is this expected?
• If i connect to all chains independently then the connection does not break
• Wallet connect does not work, screenshot of console attached

[ebma]

If i connect only to Pendulum network then the connection breaks when switching to other chains, is this expected?

Hmm well I can reproduce that it breaks on the deploy preview. It worked for me locally though. I'll have a look again.

Wallet connect does not work, screenshot of console attached

Right, sorry. We need to whitelist all the domains on our walletconnect account. I whitelisted the domain of this deploy preview now so it should work. I'll let you know when I looked into the other bug again so you can test.

[ebma]

Troubleshooting this was way too annoying. I think I was able to pin it down though. The call to wallet.enable() here sometimes fails, ie. the await statement just doesn't resolve. This only happens on the deploy preview though. I found this ticket which is somehow similar. Adding a small timeout to the initialization of the wallet provider seems to alleviate the issue. I suppose it doesn't happen locally because the page is served faster and thus maybe the wallet provider is injected faster? I am not 100% sure what the problem is but neither are the maintainers in the talisman repo.

@prayagd please give it another shot and let me know if it works now.

[Sharqiewicz]

Well done! ✅ It works. I hope Talisman will address this in the future, so we won’t need to rely on setTimeout, because using setTimeout is not ideal

[ebma]

@prayagd can you also try again and approve if it works?

[prayagd]

LGTM, we can merge