Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nav sidebar collapse behaviour to allow only one expanded menu at a time, Refactor Nav structure #568

Merged
merged 17 commits into from
Sep 30, 2024

Conversation

Sharqiewicz
Copy link
Collaborator

🦈 PR - ready 🟢

After the implementation of ForexAMM for Pendulum, we noticed unexpected behaviour in the Nav Sidebar. Previously, with only one CollapseMenu, this issue wasn’t present. Now that multiple CollapseMenus are available, we want to ensure that only one menu can be expanded at a time for better user experience and interface consistency.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit f191c25
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66fa826b332c960008fcb644
😎 Deploy Preview https://deploy-preview-568--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz
Copy link
Collaborator Author

@ebma Ready for review

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 let's merge

@Sharqiewicz Sharqiewicz merged commit 54f0113 into main Sep 30, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the refactor-nav-structure branch September 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants