-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump polkadot api versions #563
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✅, just some clarification comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I was able to simplify this further and get rid of the fee name checks. The problem was that I missed updating the Neither our old v0.9.42 runtimes are using This is great as it makes the changes of this PR even simpler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you could simplify this further as 0.9.42 already used the new types.
By the way: the removal of src/services/stats/index.tsx
is an unrelated change, correct? You just wanted to clean it up here because you saw that it is not used anywhere?
Yes, |
Due to the runtime upgrade to polkadot v1.1.0 on Foucoco, the portal is not able to properly connect to Foucoco anymore.
When loading the Spacewalk or Staking pages, the following error is thrown
This is because some RPC methods were deprecated and are not available anymore.
Solution
We only need to bump the polkadot.js dependency versions. The later versions are aware of the RPC method deprecation and handle the change properly.