Add link to subscan explore on the transaction status pop up #557
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ebma Your changes are great ✅ very good job ⭐ |
…action-status-pop-up
There was a problem hiding this comment.
Approved!
A couple of changes just reorder class names. Is this a new prettier or linter fix setting or do local setups between team members deviate or are formatting checks not properly added to CI?
Would be good to fix this in the config so that we can avoid changes in PRs like this in the future.
| {!mutation.isSuccess && !!errorMsg && <p className="text-center mt-1">{errorMsg}</p>} | ||
| {!mutation.isSuccess && !!errorMsg && <p className="mt-1 text-center">{errorMsg}</p>} | ||
| <div className="mt-6"></div> | ||
| {!!explorerUrl && ( |
There was a problem hiding this comment.
Just a question because it is the first time I see it that way: Is there a difference between !!explorerUrl && ... and explorerUrl && since explorerUrl can only be undefined or a truthy (nonempty) string?
React considers
falseas a “hole” in the JSX tree, just likenullorundefined, and doesn’t render anything in its place.
There was a problem hiding this comment.
No you are right, there is no need for this here. I just used it to cast it to a boolean value but that's not really necessary here. Removed.
There was a problem hiding this comment.
I think the reordering of the classNames happens because of this plugin that @Sharqiewicz added not too long ago. I locally ran prettier on all files and there were a lot of changes. It's probably best to move this to an extra PR, possibly also adding a precommit hook for running prettier automatically.
| {!mutation.isSuccess && !!errorMsg && <p className="text-center mt-1">{errorMsg}</p>} | ||
| {!mutation.isSuccess && !!errorMsg && <p className="mt-1 text-center">{errorMsg}</p>} | ||
| <div className="mt-6"></div> | ||
| {!!explorerUrl && ( |
There was a problem hiding this comment.
No you are right, there is no need for this here. I just used it to cast it to a boolean value but that's not really necessary here. Removed.
…action-status-pop-up
ebma
deleted the
471-add-link-to-subscan-explore-on-the-transaction-status-pop-up
branch
|
I followed up to this in #567. |
I did not test how it looks for the 'Transaction failed' case as forcing the extrinsic to fail is not easy.
Note: This currently includes changes that enable Nabla on Pendulum but this is just to facilitate testing with the deploy preview and will be removed before merge.
Closes #471.
The button looks like this and it will link to transactions like this.
