Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show skeleton on Spacewalk transactions page #551

Conversation

ebma
Copy link
Member

@ebma ebma commented Sep 3, 2024

Shows a skeleton for the Spacewalk transactions table when the data is still loading.
While the issue ticket asks for a spinner, I think the skeleton is prettier.

Note: There is a little bug that the skeleton does not immediately show when you refresh the page on the Spacewalk transactions view. I'm not sure why exactly and I tried some things to prevent this but it's just a minor issue and unlikely that users will notice as this only pops up when you manually refresh the page on that view.

Closes #513.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 65d7c22
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66e19c530eeb4e0008efd030
😎 Deploy Preview https://deploy-preview-551--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ebma ebma force-pushed the 513-transactions-page-on-the-portal-initially-shows-empty-table-without-loading-spinner branch from a6cae9f to f285ca9 Compare September 3, 2024 15:48
@ebma ebma marked this pull request as ready for review September 3, 2024 15:50
@ebma ebma changed the title WIP transactions page on the portal initially shows empty table without loading spinner Show skeleton on Spacewalk transactions page Sep 3, 2024
Copy link
Collaborator

@Sharqiewicz Sharqiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebma Great changes! 🚀 I noticed one small thing: when I start localhost and am not logged in, the table loads endlessly

src/pages/spacewalk/transactions/index.tsx Outdated Show resolved Hide resolved
src/components/Table/index.tsx Show resolved Hide resolved
@ebma
Copy link
Member Author

ebma commented Sep 10, 2024

@pendulum-chain/product can someone please have a look at the deploy preview and let me know if it's okay the way it works now? Since technically, the transactions need to take the activeBlockNumber into account, the table will now show the skeleton each time a new block is coming in. Because for each new block, the table is populated anew. In almost all cases the table will not change though. Please let me know if you think the repeated loading indication is too much and I can change it to only show at the beginning.

@annatekl
Copy link

While the issue ticket asks for a spinner, I think the skeleton is prettier.

The table loading time is still quite long

@ebma
Copy link
Member Author

ebma commented Sep 11, 2024

Only if you refresh the page on the transactions page or what exactly do you think is long? The time until the skeleton shows or the duration of how long the skeleton stays?

@annatekl
Copy link

Only if you refresh the page on the transactions page or what exactly do you think is long? The time until the skeleton shows or the duration of how long the skeleton stays?

the duration the skeleton stays

@ebma
Copy link
Member Author

ebma commented Sep 11, 2024

That's not what the related issue #513 was about though, was it? 😅 It's about showing a loading indicator and not reducing the loading time.

@annatekl
Copy link

That's not what the related issue #513 was about though, was it? 😅 It's about showing a loading indicator and not reducing the loading time.

true, lets do it this way

This is to prevent rerenders of the table for each new active block
This prevents the timestamps of the entries in the table to change on each rerender
@ebma ebma merged commit 375f530 into main Sep 11, 2024
5 checks passed
@ebma ebma deleted the 513-transactions-page-on-the-portal-initially-shows-empty-table-without-loading-spinner branch September 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions page on the portal initially shows empty table without loading spinner
3 participants