-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show skeleton on Spacewalk transactions page #551
Show skeleton on Spacewalk transactions page #551
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a6cae9f
to
f285ca9
Compare
…y-shows-empty-table-without-loading-spinner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebma Great changes! 🚀 I noticed one small thing: when I start localhost and am not logged in, the table loads endlessly
@pendulum-chain/product can someone please have a look at the deploy preview and let me know if it's okay the way it works now? Since technically, the transactions need to take the |
The table loading time is still quite long |
Only if you refresh the page on the transactions page or what exactly do you think is long? The time until the skeleton shows or the duration of how long the skeleton stays? |
the duration the skeleton stays |
That's not what the related issue #513 was about though, was it? 😅 It's about showing a loading indicator and not reducing the loading time. |
true, lets do it this way |
This is to prevent rerenders of the table for each new active block This prevents the timestamps of the entries in the table to change on each rerender
Shows a skeleton for the Spacewalk transactions table when the data is still loading.
While the issue ticket asks for a spinner, I think the skeleton is prettier.
Note: There is a little bug that the skeleton does not immediately show when you refresh the page on the Spacewalk transactions view. I'm not sure why exactly and I tried some things to prevent this but it's just a minor issue and unlikely that users will notice as this only pops up when you manually refresh the page on that view.
Closes #513.