Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide Insufficient Balance Popup if balance is not ready #548

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

Sharqiewicz
Copy link
Collaborator

🦈

When I am loading the portal (dashboard), it shows me a warning about insufficient funds to execute transactions. After loading this warning disappears, but because the loading takes quite a while, I am already concerned as a user, if someone hacked my PEN balance

Expected behavior

My expectation as a user would be, that instead of showing a warning, I could see some info, that the portal is loading.

  • Show Skeleton component when Dashboard is loading
  • Show no GET PEN when the page is loading

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 9396e02
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66d6d553f79149000773b6d3
😎 Deploy Preview https://deploy-preview-548--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz
Copy link
Collaborator Author

@pendulum-chain/devs Ready for review. Minor change

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

@Sharqiewicz Sharqiewicz merged commit 250f257 into main Sep 3, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 511-add-loading-for-dashboard-and-get-pen branch September 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants