Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update yarn, update readme.md on corepack #547

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

Sharqiewicz
Copy link
Collaborator

Problem:

The packageManager field in package.json specifies the package manager and its version for the project. However, it doesn't enforce the use of this package manager on its own.

What to do?

  • Update Yarn version
  • Add the note below to readme.md:
Enable Corepack by executing the command `corepack enable`. 
Corepack is included by default in Node.js, it manages the Yarn version specified in the `packageManager` field.

**Important:** Modern [Yarn](https://yarnpkg.com/getting-started/install) releases should not be installed globally or via npm - use Corepack instead.

@Sharqiewicz Sharqiewicz linked an issue Sep 2, 2024 that may be closed by this pull request
@Sharqiewicz
Copy link
Collaborator Author

@pendulum-chain/devs Ready for review. Minor change

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 768c6a2
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66d5d098c645c300089095a9
😎 Deploy Preview https://deploy-preview-547--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting addition, I wasn't aware of this problem 👍 I tested it locally and encountered some issues with volta but I added a note to the readme to fix this.

@Sharqiewicz
Copy link
Collaborator Author

@ebma Thanks 🦈

@Sharqiewicz Sharqiewicz merged commit 03fb3e8 into main Sep 3, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 545-add-corepack-to-readme-update-packagemanager branch September 3, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Corepack to readme, update packageManager
2 participants