-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch assets from batching server #542
fetch assets from batching server #542
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…pdate-filter-to-dashboard
@pendulum-chain/devs Ready for review. The prices won't work on deploy preview - CORS policy of the browser is going to block communication between the batching server and the portal. In order to test it you have to run it locally, with local proxy server setup. CORS policy of the batching-server is set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally with a local batching server (with CORS enabled) and the proxy server and I can confirm the changes work. Great job @Sharqiewicz 👍 Let's wait with merging until the new batching server is redeployed.
@ebma Please merge when the batching server is redeployed |
Will do. This will probably happen on Monday, see the related change request here. |
…pdate-filter-to-dashboard
🦈
Local Development
The proxy server is implemented to bypass CORS-related issues when running the portal locally.
Unlike the browser, the proxy server does not trigger a preflight request, which is initiated by the browser to check permissions for cross-origin resource sharing (CORS). The preflight request can block communication between the portal and the batching server, causing interruptions in the connection.