Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update disclaimer texts for Amplitude and Pendulum #538

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Update disclaimer texts for Amplitude and Pendulum #538

merged 5 commits into from
Aug 1, 2024

Conversation

ebma
Copy link
Member

@ebma ebma commented Jul 30, 2024

Updates the disclaimer texts shown in the issue dialog.

Closes #458 and closes #459.

@ebma ebma linked an issue Jul 30, 2024 that may be closed by this pull request
Update the disclaimer for Amplitude Spacewalk #458
Closed
3 tasks
@ebma ebma requested review from Sharqiewicz and prayagd July 30, 2024 16:09
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 4eb74b6
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66aa39fad120870008d44057
😎 Deploy Preview https://deploy-preview-538--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prayagd
prayagd requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@prayagd prayagd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebma

  • Is it possible to add a underline or make the colour of the support link darker to make it standout? I feel its not that clear that its clickable. This is for Pendulum, its perfect for Amplitude

@ebma
Copy link
Member Author

ebma commented Jul 31, 2024 •
edited
Loading

I changed it to a lighter color and italic font added an underline. Do you think it's better now @prayagd? Otherwise please tell me which color you'd prefer, it's not easy to find a good one 😅

prayagd
prayagd approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@prayagd prayagd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ebma ebma merged commit 723bf7e into main Aug 1, 2024
5 checks passed
@ebma ebma deleted the 458-update-the-disclaimer-for-amplitude-spacewalk branch August 1, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharqiewicz Sharqiewicz Sharqiewicz approved these changes

@prayagd prayagd prayagd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the disclaimer for Pendulum Spacewalk Update the disclaimer for Amplitude Spacewalk
3 participants
@ebma @Sharqiewicz @prayagd