495 enable circle eurcs as spacewalk asset on the portal on pendulum

[ebma]

Refactors the logic to get an icon so that it checks using includes and not for perfect matches and adds an additional check to decide between the mEURC and cEURC icons.

With these changes, the Circle EURC icon should show properly in the dashboard as well as the asset selector in the Spacewalk menus. We don't care about Nabla yet as that's a special use case where we don't need to have a perfect solution just yet.

Closes #495.

[netlify]

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name	Link
🔨 Latest commit	5f5f58d
🔍 Latest deploy log	https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66a005995f47280008de2cb9
😎 Deploy Preview	https://deploy-preview-525--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Sharqiewicz]

LGTM 🚀 ✅

[ebma]

@Sharqiewicz I noticed that all EURC icons are now showing the Circle EURc though I was not yet able to pin down why. This happens in the dashboard as well as the asset selector of the spacewalk dialogs. Very weird.

[Sharqiewicz]

@Sharqiewicz I noticed that all EURC icons are now showing the Circle EURc though I was not yet able to pin down why. This happens in the dashboard as well as the asset selector of the spacewalk dialogs. Very weird.

No asset matches the Mykobo issuer address, I am resolving it

[ebma]

I also thought that something was wrong with that match but actually, if you add plenty of log statements you will see that sometimes, it is able to match it. I think the issuer is sometimes not getting passed into the function and that's why it will return the cEURC icon by default.

I was not able to find the places where the issuer is not passed though.

[Sharqiewicz]

@ebma The issue was that we were invoking getAssetIcon two times, first for getPolkadotAssetIcon and then for getStellarAssetIcon. getPolkadotAssetIcon had always value of cEURC and getStellarAssetIcon had the value of mEURC. The return condition was polkadotIcon || stellarIcon || defaultIcon; so it was always returning cEURC.

[ebma]

Ahh I see, thanks a lot for debugging and fixing this @Sharqiewicz! 🙏 I'll merge it then.