Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 50% and Max from the Backstop pool withdraw UI #496

Merged

Conversation

Sharqiewicz
Copy link
Collaborator

What:

Remove 50% and Max from the Backstop pool withdraw UI

✅ Change color of Nabla dialog inputs
✅ Fix Nabla loading buttons styles
✅ Remove 50% and Max buttons
✅ Refactor Nabla modals to use reusable dialog components
✅ Add a space between Nabla Pool dialog asset and asset name ( Closes: #489 )

Closes: #478

@Sharqiewicz Sharqiewicz requested review from ebma and prayagd June 10, 2024 12:38
@Sharqiewicz Sharqiewicz linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 8117ef0
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/667c1ec626d2ba0008f9ce2d
😎 Deploy Preview https://deploy-preview-496--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the change for #489 is as expected.

For the '50%' and 'MAX' button, ticket #478 specified that these should only be removed when withdrawing, not for depositing. So we should not remove them altogether but just hide them in these cases.

@Sharqiewicz
Copy link
Collaborator Author

@ebma I have corrected what you asked for. Now when you click 50% or Max you may find that too many decimals are shown. This is corrected in PR #506 so there is no point in implementing it in this PR

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for swapping but the actions are now also missing for the deposit screen of the backstop pool which they should not.

image

src/components/Form/From/AvailableActions/index.tsx Outdated Show resolved Hide resolved
@Sharqiewicz
Copy link
Collaborator Author

@ebma I've added for Backstop Pool Deposit and I changed the naming

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, works now 👍

@Sharqiewicz Sharqiewicz merged commit 7f43f1f into main Jun 27, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 478-remove-50-and-max-from-the-backstop-pool-withdraw-ui branch June 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants