Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nabla modals #490

Merged

Conversation

Sharqiewicz
Copy link
Collaborator

What:

After a user successfully deposits asset into the swap pool, the user still sees the Deposit pop-up after the successful confirmation pop-up is closed

How:

✅ Use reusable component for Nabla
✅ Fix onClose for Nabla dialogs

@Sharqiewicz Sharqiewicz requested review from ebma and prayagd June 3, 2024 14:03
@Sharqiewicz Sharqiewicz linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit f4b5fc8
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/665ee19dcd97a60008d6f6e3
😎 Deploy Preview https://deploy-preview-490--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

@Sharqiewicz Sharqiewicz merged commit 937e9b7 into main Jun 4, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 472-deposit-screen-does-not-closes-after-successful-deposit branch June 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit screen does not closes after successful deposit
2 participants