-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Nabla swap design #483
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebma I applied the changes you mentioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks 👍 something is off though. I noticed that on Foucoco, no matter which asset I'm using in the swap form, it's limited to 12 decimals.
If you check the foucoco squid with the following query, you'll see that the mock tokens have varying decimals though and not always just 12
.
query MyQuery {
nablaTokens {
decimals
name
id
symbol
}
}
Did you log and check the values that maxBalance?.decimals
gets? Maybe it's always undefined for some reason.
@ebma It works correctly for me. I receive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me then
What:
✅ Remove NumberInput and replace any use of it with NumericInput
✅ Change texts
Closes: #473