-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/improve paths #460
Chore/improve paths #460
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebma I have implemented dynamic imports with dynamic paths using const pages = ✨ Key Improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I like it 👌
@ebma changed ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What:
The paths in the app are just
strings
that can cause many problems, such as misspelling, pointing to a non-existent page (after renaming).How:
✅ Change the paths to be included in the
PATHS
enum. Enum is used for redirection throughout the application.✅ Remove unused Stats page
✅ Fixed error appearing in the paths that only has the network name like:
portal.pendulumchain.org/amplitude
portal.pendulumchain.org/pendulum
portal.pendulumchain.org/foucoco
- now it's redirecting to the dashboard