fix: the calculation of the security deposit amount

[Sharqiewicz]

What:

fix the calculation of the security deposit amount

How:

💥 I started from GET PEN branch #413 because there it includes refactored usePriceFetcher

✅ 🦖 Implement calculateGriefingCollateral for FeeBox > Security Deposit
✅ 🧪 Implement tests for calculateGriefingCollateral

Comments:

Closes: #416

[netlify]

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name	Link
🔨 Latest commit	f6e579d
🔍 Latest deploy log	https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/667b080d10b2de00087b2863
😎 Deploy Preview	https://deploy-preview-436--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ebma]

yarn.lock changes

Summary

Status	Count
	48
	434
	4
	25

Click to toggle table visibility

Name	Status	Previous	Current
@aashutoshrathi/word-wrap		1.2.6	-
@adobe/css-tools		4.3.2	4.3.3
@ampproject/remapping		2.2.1	2.3.0
@babel/code-frame		7.23.5	7.24.2
@babel/compat-data		7.23.5	7.24.4
@babel/core		7.23.6	7.24.5
@babel/generator		7.23.6	7.24.5
@babel/helper-create-class-features-plugin		7.23.6	7.24.5
@babel/helper-define-polyfill-provider		0.4.4	0.6.2
@babel/helper-member-expression-to-functions		7.23.0	7.24.5
@babel/helper-module-imports		7.22.15	7.24.3
@babel/helper-module-transforms		7.23.3	7.24.5
@babel/helper-plugin-utils		7.22.5	7.24.5
@babel/helper-replace-supers		7.22.20	7.24.1
@babel/helper-simple-access		7.22.5	7.24.5
@babel/helper-split-export-declaration		7.22.6	7.24.5
@babel/helper-string-parser		7.23.4	7.24.1
@babel/helper-validator-identifier		7.22.20	7.24.5
@babel/helper-wrap-function		7.22.20	7.24.5
@babel/helpers		7.23.6	7.24.5
@babel/highlight		7.23.4	7.24.5
@babel/parser		7.23.6	7.24.5
@babel/plugin-bugfix-firefox-class-in-computed-class-key		-	7.24.5
@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression		7.23.3	7.24.1
@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining		7.23.3	7.24.1
@babel/plugin-bugfix-v8-static-class-fields-redefine-readonly		7.23.3	7.24.1
@babel/plugin-syntax-flow		7.23.3	7.24.1
@babel/plugin-syntax-import-assertions		7.23.3	7.24.1
@babel/plugin-syntax-import-attributes		7.23.3	7.24.1
@babel/plugin-syntax-jsx		7.23.3	7.24.1
@babel/plugin-syntax-typescript		7.23.3	7.24.1
@babel/plugin-transform-arrow-functions		7.23.3	7.24.1
@babel/plugin-transform-async-generator-functions		7.23.4	7.24.3
@babel/plugin-transform-async-to-generator		7.23.3	7.24.1
@babel/plugin-transform-block-scoped-functions		7.23.3	7.24.1
@babel/plugin-transform-block-scoping		7.23.4	7.24.5
@babel/plugin-transform-class-properties		7.23.3	7.24.1
@babel/plugin-transform-class-static-block		7.23.4	7.24.4
@babel/plugin-transform-classes		7.23.5	7.24.5
@babel/plugin-transform-computed-properties		7.23.3	7.24.1
@babel/plugin-transform-destructuring		7.23.3	7.24.5
@babel/plugin-transform-dotall-regex		7.23.3	7.24.1
@babel/plugin-transform-duplicate-keys		7.23.3	7.24.1
@babel/plugin-transform-dynamic-import		7.23.4	7.24.1
@babel/plugin-transform-exponentiation-operator		7.23.3	7.24.1
@babel/plugin-transform-export-namespace-from		7.23.4	7.24.1
@babel/plugin-transform-flow-strip-types		7.23.3	7.24.1
@babel/plugin-transform-for-of		7.23.6	7.24.1
@babel/plugin-transform-function-name		7.23.3	7.24.1
@babel/plugin-transform-json-strings		7.23.4	7.24.1
@babel/plugin-transform-literals		7.23.3	7.24.1
@babel/plugin-transform-logical-assignment-operators		7.23.4	7.24.1
@babel/plugin-transform-member-expression-literals		7.23.3	7.24.1
@babel/plugin-transform-modules-amd		7.23.3	7.24.1
@babel/plugin-transform-modules-commonjs		7.23.3	7.24.1
@babel/plugin-transform-modules-systemjs		7.23.3	7.24.1
@babel/plugin-transform-modules-umd		7.23.3	7.24.1
@babel/plugin-transform-new-target		7.23.3	7.24.1
@babel/plugin-transform-nullish-coalescing-operator		7.23.4	7.24.1
@babel/plugin-transform-numeric-separator		7.23.4	7.24.1
@babel/plugin-transform-object-rest-spread		7.23.4	7.24.5
@babel/plugin-transform-object-super		7.23.3	7.24.1
@babel/plugin-transform-optional-catch-binding		7.23.4	7.24.1
@babel/plugin-transform-optional-chaining		7.23.4	7.24.5
@babel/plugin-transform-parameters		7.23.3	7.24.5
@babel/plugin-transform-private-methods		7.23.3	7.24.1
@babel/plugin-transform-private-property-in-object		7.23.4	7.24.5
@babel/plugin-transform-property-literals		7.23.3	7.24.1
@babel/plugin-transform-react-display-name		7.23.3	7.24.1
@babel/plugin-transform-regenerator		7.23.3	7.24.1
@babel/plugin-transform-reserved-words		7.23.3	7.24.1
@babel/plugin-transform-shorthand-properties		7.23.3	7.24.1
@babel/plugin-transform-spread		7.23.3	7.24.1
@babel/plugin-transform-sticky-regex		7.23.3	7.24.1
@babel/plugin-transform-template-literals		7.23.3	7.24.1
@babel/plugin-transform-typeof-symbol		7.23.3	7.24.5
@babel/plugin-transform-typescript		7.23.6	7.24.5
@babel/plugin-transform-unicode-escapes		7.23.3	7.24.1
@babel/plugin-transform-unicode-property-regex		7.23.3	7.24.1
@babel/plugin-transform-unicode-regex		7.23.3	7.24.1
@babel/plugin-transform-unicode-sets-regex		7.23.3	7.24.1
@babel/preset-env		7.23.6	7.24.5
@babel/preset-typescript		7.23.3	7.24.1
@babel/runtime		7.23.6	7.24.5
@babel/template		7.22.15	7.24.0
@babel/traverse		7.23.6	7.24.5
@babel/types		7.23.6	7.24.5
@eslint/js		8.55.0	8.57.0
@graphql-codegen/add		5.0.0	5.0.2
@graphql-codegen/cli		5.0.0	5.0.2
@graphql-codegen/client-preset		4.1.0	4.2.5
@graphql-codegen/core		4.0.0	4.0.2
@graphql-codegen/gql-tag-operations		4.0.1	4.0.6
@graphql-codegen/plugin-helpers		5.0.1	5.0.3
@graphql-codegen/schema-ast		4.0.0	4.0.2
@graphql-codegen/typed-document-node		5.0.1	5.0.6
@graphql-codegen/typescript		4.0.1	4.0.6
@graphql-codegen/typescript-operations		4.0.1	4.2.0
@graphql-codegen/visitor-plugin-common		4.0.1	5.1.0
@graphql-tools/apollo-engine-loader		8.0.0	8.0.1
@graphql-tools/batch-execute		9.0.2	9.0.4
@graphql-tools/code-file-loader		8.0.3	8.1.1
@graphql-tools/delegate		10.0.3	10.0.7
@graphql-tools/executor		1.2.0	1.2.6
@graphql-tools/executor-graphql-ws		1.1.1	1.1.2
@graphql-tools/executor-http		1.0.5	1.0.9
@graphql-tools/executor-legacy-ws		1.0.5	1.0.6
@graphql-tools/git-loader		8.0.3	8.0.5
@graphql-tools/github-loader		8.0.0	8.0.1
@graphql-tools/graphql-file-loader		8.0.0	8.0.1
@graphql-tools/graphql-tag-pluck		8.1.0	8.3.0
@graphql-tools/import		7.0.0	7.0.1
@graphql-tools/json-file-loader		8.0.0	8.0.1
@graphql-tools/load		8.0.1	8.0.2
@graphql-tools/merge		9.0.1	9.0.3
@graphql-tools/prisma-loader		8.0.2	8.0.4
@graphql-tools/relay-operation-optimizer		7.0.0	7.0.1
@graphql-tools/schema		10.0.2	10.0.3
@graphql-tools/url-loader		8.0.1	8.0.2
@graphql-tools/utils		10.0.11	10.2.0
@graphql-tools/wrap		10.0.1	10.0.5
@heroicons/react		2.0.18	2.1.3
@humanwhocodes/config-array		0.11.13	0.11.14
@humanwhocodes/object-schema		2.0.1	2.0.3
@ioredis/commands		1.2.0	-
@jridgewell/gen-mapping		0.3.3	0.3.5
@jridgewell/resolve-uri		3.1.1	3.1.2
@jridgewell/set-array		1.1.2	1.2.1
@jridgewell/trace-mapping		0.3.20	0.3.25
@jspm/core		2.0.1	-
@noble/curves		1.3.0	1.4.0
@noble/hashes		1.3.3	1.4.0
@noble/secp256k1		-	1.7.1
@npmcli/agent		2.2.0	2.2.2
@npmcli/arborist		7.2.2	7.5.0
@npmcli/config		8.0.3	8.3.0
@npmcli/disparity-colors		3.0.0	2.0.0
@npmcli/git		5.0.3	5.0.6
@npmcli/installed-package-contents		2.0.2	2.1.0
@npmcli/map-workspaces		3.0.4	3.0.6
@npmcli/metavuln-calculator		7.0.0	7.1.0
@npmcli/package-json		5.0.0	5.1.0
@npmcli/promise-spawn		7.0.0	7.0.1
@npmcli/query		3.0.1	3.1.0
@npmcli/redact		-	1.1.0
@npmcli/run-script		7.0.2	8.1.0
@octokit/core		5.0.2	5.2.0
@octokit/endpoint		9.0.4	9.0.5
@octokit/graphql		7.0.2	7.1.0
@octokit/openapi-types		19.1.0	22.2.0
@octokit/plugin-paginate-rest		9.1.5	9.2.1
@octokit/plugin-throttling		8.1.3	8.2.0
@octokit/request		8.1.6	8.4.0
@octokit/request-error		5.0.1	5.1.0
@octokit/types		12.4.0	13.5.0
@parcel/watcher		2.4.0	2.4.1
@parcel/watcher-android-arm64		2.4.0	2.4.1
@parcel/watcher-darwin-arm64		2.4.0	2.4.1
@parcel/watcher-darwin-x64		2.4.0	2.4.1
@parcel/watcher-freebsd-x64		2.4.0	2.4.1
@parcel/watcher-linux-arm-glibc		2.4.0	2.4.1
@parcel/watcher-linux-arm64-glibc		2.4.0	2.4.1
@parcel/watcher-linux-arm64-musl		2.4.0	2.4.1
@parcel/watcher-linux-x64-glibc		2.4.0	2.4.1
@parcel/watcher-linux-x64-musl		2.4.0	2.4.1
@parcel/watcher-wasm		2.4.0	2.4.1
@parcel/watcher-win32-arm64		2.4.0	2.4.1
@parcel/watcher-win32-ia32		2.4.0	2.4.1
@parcel/watcher-win32-x64		2.4.0	2.4.1
@peculiar/webcrypto		1.4.3	1.4.6
@polkadot-api/client		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot-api/json-rpc-provider		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot-api/json-rpc-provider-proxy		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot-api/metadata-builders		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot-api/substrate-bindings		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot-api/substrate-client		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot-api/utils		-	0.0.1-492c132563ea6b40ae1fc5470dec4cd18768d182.1.0
@polkadot/api		10.11.1	10.13.1
@polkadot/api-augment		10.11.1	10.13.1
@polkadot/api-base		10.11.1	10.13.1
@polkadot/api-contract		10.11.1	10.13.1
@polkadot/api-derive		10.11.1	10.13.1
@polkadot/extension-dapp		0.46.6	0.46.9
@polkadot/extension-inject		0.46.6	0.46.9
@polkadot/keyring		12.6.1	12.6.2
@polkadot/networks		12.6.1	12.6.2
@polkadot/rpc-augment		10.11.1	10.13.1
@polkadot/rpc-core		10.11.1	10.13.1
@polkadot/rpc-provider		10.11.1	10.13.1
@polkadot/types		10.11.1	10.13.1
@polkadot/types-augment		10.11.1	10.13.1
@polkadot/types-codec		10.11.1	10.13.1
@polkadot/types-create		10.11.1	10.13.1
@polkadot/types-known		10.11.1	10.13.1
@polkadot/types-support		10.11.1	10.13.1
@polkadot/util		12.6.1	12.6.2
@polkadot/util-crypto		12.6.1	12.6.2
@polkadot/x-bigint		12.6.1	12.6.2
@polkadot/x-fetch		12.6.1	12.6.2
@polkadot/x-global		12.6.1	12.6.2
@polkadot/x-randomvalues		12.6.1	12.6.2
@polkadot/x-textdecoder		12.6.1	12.6.2
@polkadot/x-textencoder		12.6.1	12.6.2
@polkadot/x-ws		12.6.1	12.6.2
@preact/preset-vite		2.7.0	2.8.2
@prefresh/vite		2.4.4	2.4.5
@remix-run/router		1.13.1	1.16.0
@scure/base		1.1.4	1.1.6
@semantic-release/github		9.2.5	9.2.6
@semantic-release/npm		11.0.2	11.0.3
@sigstore/bundle		2.1.0	2.3.1
@sigstore/core		-	1.1.0
@sigstore/protobuf-specs		0.2.1	0.3.1
@sigstore/sign		2.2.0	2.3.0
@sigstore/tuf		2.2.0	2.3.2
@sigstore/verify		-	1.2.0
@sindresorhus/merge-streams		1.0.0	2.3.0
@sinonjs/commons		3.0.0	3.0.1
@substrate/connect		0.7.35	0.8.8
@substrate/connect-extension-protocol		1.0.1	2.0.0
@substrate/connect-known-chains		-	1.1.4
@substrate/light-client-extension-helpers		-	0.0.4
@substrate/smoldot-light		-	0.7.9
@substrate/ss58-registry		1.44.0	1.47.0
@talismn/connect-components		1.1.7	1.1.8
@talismn/connect-ui		1.1.2	1.1.3
@talismn/connect-wallets		1.2.3	1.2.5
@tanstack/react-table		8.10.7	8.16.0
@tanstack/table-core		8.10.7	8.16.0
@testing-library/react-hooks		8.0.1	-
@tsconfig/node10		1.0.9	1.0.11
@types/babel__generator		7.6.7	7.6.8
@types/babel__traverse		7.20.4	7.20.5
@types/jest		29.5.11	29.5.12
@types/json-stable-stringify		1.0.36	-
@types/lodash		4.14.202	4.17.0
@types/luxon		3.3.7	3.4.2
@types/node		18.19.3	18.19.31
@types/node-fetch		-	2.6.11
@types/prop-types		15.7.11	15.7.12
@types/react		18.2.43	18.3.1
@types/react-dom		18.2.17	18.3.0
@types/react-table		7.7.18	7.7.20
@types/scheduler		0.16.8	-
@types/semver		7.5.6	7.5.8
@types/websocket		-	1.0.10
@typescript-eslint/eslint-plugin		5.62.0	7.8.0
@typescript-eslint/parser		5.62.0	7.8.0
@typescript-eslint/scope-manager		5.62.0	7.8.0
@typescript-eslint/type-utils		5.62.0	7.8.0
@typescript-eslint/types		5.62.0	7.8.0
@typescript-eslint/typescript-estree		5.62.0	7.8.0
@typescript-eslint/utils		5.62.0	7.8.0
@typescript-eslint/visitor-keys		5.62.0	7.8.0
@walletconnect/core		2.11.1	2.12.2
@walletconnect/logger		2.0.1	2.1.2
@walletconnect/relay-api		1.0.9	1.0.10
@walletconnect/sign-client		2.11.1	2.12.2
@walletconnect/types		2.11.1	2.12.2
@walletconnect/universal-provider		2.11.1	2.12.2
@walletconnect/utils		2.11.1	2.12.2
@whatwg-node/fetch		0.9.14	0.9.17
@whatwg-node/node-fetch		0.5.2	0.5.11
abort-controller		3.0.0	-
acorn-walk		8.3.1	8.3.2
agent-base		7.1.0	7.1.1
ansi-escapes		6.2.0	6.2.1
are-we-there-yet		4.0.1	4.0.2
array-buffer-byte-length		1.0.0	1.0.1
array-includes		3.1.7	3.1.8
array.prototype.findlast		-	1.2.5
array.prototype.toreversed		-	1.1.2
array.prototype.tosorted		1.1.2	1.1.3
arraybuffer.prototype.slice		1.0.2	1.0.3
asynciterator.prototype		1.0.0	-
autoprefixer		10.4.16	10.4.19
available-typed-arrays		1.0.5	1.0.7
babel-plugin-polyfill-corejs2		0.4.7	0.4.11
babel-plugin-polyfill-corejs3		0.8.7	0.10.4
babel-plugin-polyfill-regenerator		0.5.4	0.6.2
binary-extensions		2.2.0	2.3.0
browserslist		4.22.2	4.23.0
buffer		6.0.3	5.7.1
bufferutil		-	4.0.8
builtins		5.0.1	5.1.0
cacache		18.0.1	18.0.2
call-bind		1.0.5	1.0.7
caniuse-lite		1.0.30001568	1.0.30001614
chokidar		3.5.3	3.6.0
cidr-regex		4.0.3	4.0.5
cjs-module-lexer		1.2.3	1.3.1
cli-table3		0.6.3	0.6.4
cluster-key-slot		1.1.2	-
confbox		-	0.1.7
cookie-es		1.0.0	1.1.0
core-js-compat		3.34.0	3.37.0
crossws		0.1.1	0.2.4
css-select		4.3.0	5.1.0
d		1.0.1	1.0.2
data-view-buffer		-	1.0.1
data-view-byte-length		-	1.0.1
data-view-byte-offset		-	1.0.0
dedent		1.5.1	1.5.3
define-data-property		1.1.1	1.1.4
denque		2.1.0	-
diff		5.1.0	5.2.0
dom-serializer		1.4.1	2.0.0
domhandler		4.3.1	5.0.3
domutils		2.8.0	3.1.0
dotenv		16.3.1	16.4.5
duplexify		4.1.2	4.1.3
ed2curve		-	0.3.0
electron-to-chromium		1.4.610	1.4.751
es-abstract		1.22.3	1.23.3
es-define-property		-	1.0.0
es-errors		-	1.3.0
es-iterator-helpers		1.0.15	1.0.19
es-object-atoms		-	1.0.0
es-set-tostringtag		2.0.2	2.0.3
es5-ext		0.10.62	0.10.64
es6-symbol		3.1.3	3.1.4
esbuild-plugin-polyfill-node		0.3.0	-
escalade		3.1.1	3.1.2
eslint		8.55.0	8.57.0
eslint-plugin-jest		27.6.0	27.9.0
eslint-plugin-react		7.33.2	7.34.1
eslint-plugin-react-hooks		4.6.0	4.6.2
esniff		-	2.0.1
event-target-shim		5.0.1	-
fast-redact		3.3.0	3.5.0
fastq		1.15.0	1.17.1
flatted		3.2.9	3.3.1
follow-redirects		1.15.3	1.15.6
get-intrinsic		1.2.2	1.2.4
get-symbol-description		1.0.0	1.0.2
glob		10.3.10	10.3.12
globalthis		1.0.3	1.0.4
globby		14.0.0	14.0.1
graphql-ws		5.14.2	5.16.0
h3		1.10.2	1.11.1
has-property-descriptors		1.0.1	1.0.2
has-proto		1.0.1	1.0.3
has-tostringtag		1.0.0	1.0.2
hasown		2.0.0	2.0.2
he		-	1.2.0
http-proxy-agent		7.0.0	7.0.2
https-proxy-agent		7.0.2	7.0.4
ignore		5.3.0	5.3.1
immutable		4.3.4	4.3.5
import-from-esm		1.3.3	1.3.4
import-meta-resolve		4.0.0	4.1.0
ini		4.1.1	4.1.2
init-package-json		6.0.0	6.0.2
internal-slot		1.0.6	1.0.7
ioredis		5.3.2	-
ip		2.0.0	-
ip-address		-	9.0.5
iron-webcrypto		1.0.0	1.1.1
is-array-buffer		3.0.2	3.0.4
is-cidr		5.0.3	5.0.5
is-data-view		-	1.0.1
is-map		2.0.2	2.0.3
is-negative-zero		2.0.2	2.0.3
is-set		2.0.2	2.0.3
is-shared-array-buffer		1.0.2	1.0.3
is-typed-array		1.1.12	1.1.13
is-typedarray		-	1.0.0
is-weakmap		2.0.1	2.0.2
is-weakset		2.0.2	2.0.3
istanbul-lib-instrument		6.0.1	6.0.2
istanbul-reports		3.1.6	3.1.7
jose		5.1.3	5.2.4
jsbn		-	1.1.0
json-stable-stringify		1.1.0	-
jsonc-parser		3.2.1	-
jsonify		0.0.1	-
libnpmaccess		8.0.2	8.0.4
libnpmdiff		6.0.4	6.1.0
libnpmexec		7.0.5	7.0.10
libnpmfund		5.0.2	5.0.8
libnpmhook		10.0.1	10.0.3
libnpmorg		6.0.2	6.0.4
libnpmpack		6.0.4	6.0.9
libnpmpublish		9.0.3	9.0.6
libnpmsearch		7.0.1	7.0.3
libnpmteam		6.0.1	6.0.3
lilconfig		3.0.0	3.1.1
listhen		1.6.0	1.7.2
lodash.defaults		4.2.0	-
lodash.isarguments		3.1.0	-
lru-cache		10.2.0	10.2.2
magic-string		-	0.30.5
match-sorter		6.3.1	6.3.4
mime		4.0.0	4.0.3
minimatch		9.0.3	9.0.4
mlly		1.5.0	1.6.1
natural-compare-lite		1.4.0	-
nock		13.4.0	13.5.4
node-fetch-native		1.6.2	1.6.4
node-gyp		10.0.1	10.1.0
node-gyp-build		4.7.1	4.8.0
node-html-parser		-	6.1.13
normalize-url		8.0.0	8.0.1
npm		10.2.5	10.6.0
npm-package-arg		11.0.1	11.0.2
npm-packlist		8.0.1	8.0.2
npm-profile		9.0.0	9.0.1
npm-registry-fetch		16.1.0	16.2.1
npm-run-path		5.1.0	5.3.0
nwsapi		2.2.7	2.2.9
object-is		1.1.5	1.1.6
object.entries		1.1.7	1.1.8
object.fromentries		2.0.7	2.0.8
object.hasown		1.1.3	1.1.4
object.values		1.1.7	1.2.0
ofetch		1.3.3	1.3.4
optionator		0.9.3	0.9.4
p-filter		3.0.0	4.1.0
p-map		5.5.0	7.0.2
pacote		17.0.5	18.0.2
pako		-	2.1.0
path-scurry		1.10.1	1.10.2
pkg-types		1.0.3	1.1.0
possible-typed-array-names		-	1.0.0
postcss		8.4.32	8.4.38
postcss-modules-extract-imports		3.0.0	3.1.0
postcss-modules-local-by-default		4.0.3	4.0.5
postcss-modules-scope		3.0.0	3.2.0
postcss-selector-parser		6.0.13	6.0.16
preact		10.19.3	10.21.0
proc-log		3.0.0	4.2.0
process		0.11.10	-
proggy		-	2.0.0
promise-call-limit		1.0.2	3.0.1
promzard		1.0.0	1.0.1
pure-rand		6.0.4	6.1.0
radix3		1.1.0	1.1.2
react		18.2.0	18.3.1
react-dom		18.2.0	18.3.1
react-error-boundary		3.1.4	-
react-hook-form		7.49.0	7.51.3
react-is		18.2.0	18.3.1
react-router		6.20.1	6.23.0
react-router-dom		6.20.1	6.23.0
read		2.1.0	3.0.1
readable-stream		4.4.2	3.6.2
redis-errors		1.2.0	-
redis-parser		3.0.0	-
reflect.getprototypeof		1.0.4	1.0.6
regenerator-runtime		0.14.0	0.14.1
regexp.prototype.flags		1.5.1	1.5.2
remove-accents		0.4.2	0.5.0
rfdc		1.3.0	1.3.1
safe-array-concat		1.0.1	1.1.2
safe-regex-test		1.0.0	1.0.3
sass		1.69.5	1.75.0
scale-ts		-	1.6.0
scheduler		0.23.0	0.23.2
semver		7.5.4	7.6.0
set-function-length		1.1.1	1.2.2
set-function-name		2.0.1	2.0.2
side-channel		1.0.4	1.0.6
sigstore		2.1.0	2.3.0
smoldot		2.0.7	2.0.22
socks		2.7.1	2.8.3
socks-proxy-agent		8.0.2	8.0.3
source-map		0.6.1	0.7.4
source-map-js		1.0.2	1.2.0
spdx-exceptions		2.3.0	2.5.0
spdx-expression-parse		3.0.1	4.0.0
spdx-license-ids		3.0.16	3.0.17
sprintf-js		1.0.3	1.1.3
stack-trace		-	1.0.0-pre2
standard-as-callback		2.1.0	-
string_decoder		1.3.0	1.1.1
string.prototype.matchall		4.0.10	4.0.11
string.prototype.trim		1.2.8	1.2.9
string.prototype.trimend		1.0.7	1.0.8
string.prototype.trimstart		1.0.7	1.0.8
sucrase		3.34.0	3.35.0
tailwindcss		3.3.6	3.4.3
tar		6.2.0	6.2.1
tough-cookie		4.1.3	4.1.4
traverse		0.6.7	0.6.9
ts-api-utils		-	1.3.0
tuf-js		2.1.0	2.2.0
type-fest		4.8.3	4.18.0
typed-array-buffer		1.0.0	1.0.2
typed-array-byte-length		1.0.0	1.0.1
typed-array-byte-offset		1.0.0	1.0.2
typed-array-length		1.0.4	1.0.6
typedarray-to-buffer		-	3.1.5
typedarray.prototype.slice		-	1.0.3
typescript		4.9.5	5.4.5
ufo		1.4.0	1.5.3
unstorage		1.10.1	1.10.2
urlpattern-polyfill		9.0.0	10.0.0
use-sync-external-store		1.2.0	1.2.2
utf-8-validate		-	5.0.10
utility-types		3.10.0	3.11.0
vite		3.2.7	3.2.10
web-streams-polyfill		3.2.1	3.3.3
webcrypto-core		1.7.7	1.7.9
websocket		-	1.0.34
which-collection		1.0.1	1.0.2
which-typed-array		1.1.13	1.1.15
word-wrap		-	1.2.5
ws		8.15.0	8.17.0
yaeti		-	0.0.6
yaml		2.3.4	2.4.2
yup		1.3.2	1.4.0

[ebma]

@Sharqiewicz I changed the calculation of the griefing collateral to be a hook instead of a simple function. This makes testing more complex so for simplicity I just removed the test cases you added 😬 I think mocking the hooks could be a little too much. WDYT?

Besides that, I fixed all the remaining issue and this PR is ready for a final review.

[Sharqiewicz]

@ebma Very good changes, very good collaboration on this task. I added 2 comments on what we could improve. As for testing, I think we could test the hook using @testing-library/react-hooks

[ebma]

As for testing, I think we could test the hook using @testing-library/react-hooks

I tried adding a test with that but I wasn't able to make this run unfortunately. Some things I learned:

• There is an extra preact port of this library https://github.com/testing-library/preact-hooks-testing-library. The last commit was 3 years ago, I'm not sure if this library is still required or not.
• renderHook is also available from '@testing-library/react', see note here.
• Adding the statement import { renderHook, act } from '@testing-library/react'; (or from the preact library) will make jest fail to compile the testing fail.

I did some googling but the things mentioned didn't help. For example, this comment suggests babel-jest. I saw that we already use that however, see here and here.

@Sharqiewicz any ideas?

[Sharqiewicz]

@ebmai have implemented hook tests using @testing-library/react-hooks and @testing-library/preact.

The renderHook function from @testing-library/react-hooks is utilized to properly render the hook during the test.
The waitFor function from @testing-library/preact is used to detect changes in the hook. In this scenario, the hook initially returns 0, and then, after the useEffect is fired, it returns the calculated amount.
Although waitForNextUpdate and waitFor are available in renderHook for detecting changes, they did not work as expected in this context.

[ebma]

Nice, thanks for fixing the test setup 🙏

Should we remove the dependencies to the pract-testing library then, if we don't need or use it?

Also, one thing that is unfortunate about the tests. Looking at the 'should calculate griefing collateral correctly' test case: It has the same structure as all the failing tests, except that we have another call with waitFor() to wait for the useEffect hook to fire. While this test is great, this means that our other test cases for the invalid value are not because if

    expect(result.current.eq(new Big(0))).toBeTruthy();

Always works, no matter if it's the happy or unhappy path, then this condition is not enough. Maybe we can add a timeout and check that this value doesn't change within like 1 second? Or do you have another idea @Sharqiewicz?

[ebma]

@pendulum-chain/product please review this

[vadaynujra]

@ebma I tested the following scenario:
Account with 0 PEN requesting bridging of 500 EURC - gives an accurate error message.

[vadaynujra]

The calculation of the security deposit is also accurate 43 PEN at the current value equals 2.5 Euros.

Looks good to be released @ebma @Sharqiewicz

[ebma]

@Sharqiewicz I improved the test now, please have another look and see if it looks okay to you. Then we merge 👍

Thanks for the review @vadaynujra

[Sharqiewicz]

@ebma Great changes. I approve ✅