Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update designs for Updating and Claiming staking rewards #336

Merged
merged 3 commits into from
Feb 14, 2024
Merged

feat: Update designs for Updating and Claiming staking rewards #336

merged 3 commits into from
Feb 14, 2024

Conversation

gonzamontiel
Copy link
Contributor

@gonzamontiel gonzamontiel commented Feb 13, 2024 •
edited
Loading

  • Updated design for Pendulum theme
  • Updated design for Amplitude theme
  • Responsive designs for tinier screens (still not perfect)
  • Disable Update for 15min after clicking on it

Closes #265

@gonzamontiel gonzamontiel linked an issue Feb 13, 2024 that may be closed by this pull request
Update design to update and claim staking rewards #265
Closed
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 0b642a4
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/65cbc940d9ddec0008b2bd3f
😎 Deploy Preview https://deploy-preview-336--rococo-souffle-a625f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prayagd
prayagd approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@prayagd prayagd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gonzamontiel all good was able to update and claim the rewards as per the designs.

Just one small thing, i know not scope of the ticket but would it possible to enable the unlock flow also in the same ticket? If not will create a new ticket then.

@gonzamontiel
Copy link
Contributor Author

gonzamontiel commented Feb 14, 2024 •
edited
Loading

@gonzamontiel all good was able to update and claim the rewards as per the designs.

Just one small thing, i know not scope of the ticket but would it possible to enable the unlock flow also in the same ticket? If not will create a new ticket then.

Uhm not sure what you mean, I will merge this since it closes the issue it was opened for, let's discuss and we can create another issue.

@gonzamontiel gonzamontiel merged commit 2ebc5d0 into staging Feb 14, 2024
5 checks passed
@gonzamontiel gonzamontiel deleted the 265-update-design-to-update-and-claim-staking-rewards branch February 14, 2024 18:14
ebma pushed a commit that referenced this pull request Mar 14, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
fac2c7b 
# [1.3.0](v1.2.1...v1.3.0) (2024-03-14)

### Bug Fixes

* add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909))
* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a))
* enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* Metamask Snap integration ([#315](#315)) ([978c515](978c515))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
ebma pushed a commit that referenced this pull request Mar 15, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
9b04a2b 
# [1.3.0](v1.2.1...v1.3.0) (2024-03-15)

### Bug Fixes

* add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909))
* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a))
* enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* Metamask Snap integration ([#315](#315)) ([978c515](978c515))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
ebma pushed a commit that referenced this pull request Mar 15, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
256d38e 
# [1.3.0](v1.2.1...v1.3.0) (2024-03-15)

### Bug Fixes

* add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909))
* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a))
* enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* Metamask Snap integration ([#315](#315)) ([978c515](978c515))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
@ebma
Copy link
Member

ebma commented Mar 15, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ebma ebma added the released label Mar 15, 2024
ebma pushed a commit that referenced this pull request Mar 19, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
cdbc412 
# [1.3.0](v1.2.1...v1.3.0) (2024-03-19)

### Bug Fixes

* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayagd prayagd prayagd approved these changes

@ebma ebma Awaiting requested review from ebma

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update design to update and claim staking rewards
3 participants
@gonzamontiel @ebma @prayagd