Use different plugin for polyfilling / Fix walletconnect

[ebma]

What:

The issue about the WalletConnect connection not working is fixed.

How:

Apparently the polyfills are causing some issues, see this comment. The issue was addressed by changing the polyfills.

Comments:

It happened to me that a no matching key. keychain .... error was shown in the console when trying to sign a transaction. It's not 100% clear to me why this happened but I found some related issue tickets which suggested either updating the dependencies or cleaning local storage. Deleting the walletconnect-related items from local storage and then disconnecting, reconnecting again fixed this issue for me.

Closes #327.

[netlify]

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name	Link
🔨 Latest commit	60f1269
🔍 Latest deploy log	https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/65ae915a524bdf000897173a
😎 Deploy Preview	https://deploy-preview-332--rococo-souffle-a625f5.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

yarn.lock changes

Summary

Status	Count
	63
	9
	7

Click to toggle table visibility

Name	Status	Previous	Current
@esbuild-plugins/node-globals-polyfill		0.1.1	-
@esbuild-plugins/node-modules-polyfill		0.1.4	-
@ioredis/commands		-	1.2.0
@jspm/core		-	2.0.1
@parcel/watcher		-	2.4.0
@parcel/watcher-android-arm64		-	2.4.0
@parcel/watcher-darwin-arm64		-	2.4.0
@parcel/watcher-darwin-x64		-	2.4.0
@parcel/watcher-freebsd-x64		-	2.4.0
@parcel/watcher-linux-arm-glibc		-	2.4.0
@parcel/watcher-linux-arm64-glibc		-	2.4.0
@parcel/watcher-linux-arm64-musl		-	2.4.0
@parcel/watcher-linux-x64-glibc		-	2.4.0
@parcel/watcher-linux-x64-musl		-	2.4.0
@parcel/watcher-wasm		-	2.3.0
@parcel/watcher-win32-arm64		-	2.4.0
@parcel/watcher-win32-ia32		-	2.4.0
@parcel/watcher-win32-x64		-	2.4.0
@walletconnect/core		2.10.4	2.11.0
@walletconnect/jsonrpc-ws-connection		1.0.13	1.0.14
@walletconnect/keyvaluestorage		1.0.2	1.1.1
@walletconnect/sign-client		2.10.4	2.11.0
@walletconnect/types		2.10.4	2.11.0
@walletconnect/universal-provider		2.10.4	2.11.0
@walletconnect/utils		2.10.4	2.11.0
acorn		8.11.2	8.11.3
citty		-	0.1.5
clipboardy		-	4.0.0
cluster-key-slot		-	1.1.2
consola		-	3.2.3
cookie-es		-	1.0.0
defu		-	6.1.4
denque		-	2.1.0
destr		-	2.0.2
detect-libc		-	1.0.3
esbuild-plugin-polyfill-node		-	0.3.0
get-port-please		-	3.1.2
h3		-	1.10.0
http-shutdown		-	1.2.2
idb-keyval		-	6.2.1
ioredis		-	5.3.2
iron-webcrypto		-	1.0.0
is-docker		-	3.0.0
is-inside-container		-	1.0.0
is-wsl		-	3.1.0
is64bit		-	2.0.0
isomorphic-unfetch		-	3.1.0
jsonc-parser		-	3.2.0
listhen		-	1.5.6
lodash.defaults		-	4.2.0
lodash.isarguments		-	3.1.0
lru-cache		10.0.1	10.1.0
magic-string		0.25.9	-
mlly		-	1.5.0
mri		-	1.2.0
napi-wasm		-	1.1.0
node-addon-api		-	7.1.0
node-fetch-native		-	1.6.1
node-forge		-	1.3.1
ofetch		-	1.3.3
pathe		-	1.1.2
pkg-types		-	1.0.3
radix3		-	1.1.0
redis-errors		-	1.2.0
redis-parser		-	3.0.0
rollup-plugin-inject		3.0.2	-
rollup-plugin-node-polyfills		0.2.1	-
safe-json-utils		1.1.1	-
sourcemap-codec		1.4.8	-
standard-as-callback		-	2.1.0
std-env		-	3.7.0
system-architecture		-	0.1.0
ufo		-	1.3.2
uncrypto		-	0.1.3
unenv		-	1.9.0
unfetch		-	4.2.0
unstorage		-	1.10.1
untun		-	0.1.3
uqr		-	0.1.2

[ebma]

@prayagd please check out the deploy preview and let me know if it works for you.

[TorstenStueber]

@ebma why do we need to polyfill Node.JS in a frontend application in the first place? This sounds strange to me.

Did you check whether removing this polyfill altogether works as well (see the second paragraph of this comment)?

[ebma]

Good question. I looked it up again and I found this commit. Seems like I added the polyfills for the stellar-sdk. Then I checked if there are still errors and indeed, without the polyfills the stellar-sdk throws some errors.

We could try to reduce the polyfills to the bare minimum instead of using the default configuration but I don't think that it's that important. What do you think @TorstenStueber?

[prayagd]

@ebma i am able to connect on Amplitude but it fails on Pendulum as the wallet does not load

I also see and error saying error while connecting the node

[ebma]

I think that's unrelated and more because our RPC nodes on Pendulum are still very slow and reject connections a lot.

[TorstenStueber]

@ebma about the polyfills: I remember now and never liked this part of the stellar-sdk, quite bloated and with unnecessary dependencies. Okay, so then we need to keep this.

[gonzamontiel]

Fine for me, didn't test.

[gonzamontiel]

I think that's unrelated and more because our RPC nodes on Pendulum are still very slow and reject connections a lot.

I can confirm this, we experience random failures while accessing Pendulum RPC nodes from the portal.

[prayagd]

I think that's unrelated and more because our RPC nodes on Pendulum are still very slow and reject connections a lot.
@ebma can we do anything about this? personally i think its not so nice experience to get that error often

[ebma]

Do you still experience issues @prayagd? I tested it just now, refreshing https://portal.pendulumchain.org/pendulum/dashboard quite often but it doesn't fail for me anymore.

But anyways, this is unrelated to this PR so I'll merge it now.

[ebma]

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀