Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch unstaking tokens #218

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

gonzamontiel
Copy link
Contributor

Closes #176

@gonzamontiel gonzamontiel linked an issue Jul 27, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 79a9a5a
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/64cb51ef5193310008c2e9a9
😎 Deploy Preview https://deploy-preview-218--rococo-souffle-a625f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gonzamontiel gonzamontiel requested a review from ebma July 27, 2023 11:23
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but I still find the terminology confusing.
Why are we saying 'Unbond' in one case and 'unboard' in another. Shouldn't we make that consistent? It's the same thing afterall @prayagd?
Also, Kilt is using a different terminology, ie. they phrase it as 'unlocking unstaked tokens', see here.

src/pages/collators/CollatorRewards.tsx Outdated Show resolved Hide resolved
src/pages/collators/CollatorRewards.tsx Outdated Show resolved Hide resolved
@prayagd
Copy link
Collaborator

prayagd commented Jul 28, 2023

Why are we saying 'Unbond' in one case and 'unboard' in another. Shouldn't we make that consistent? It's the same thing afterall @prayagd?

@ebma Yes they are the same, its a typo. @gonzamontiel Can we make it unbonding? I find the KILT phrase too long.

@gonzamontiel
Copy link
Contributor Author

Looks good overall but I still find the terminology confusing. Why are we saying 'Unbond' in one case and 'unboard' in another. Shouldn't we make that consistent? It's the same thing afterall @prayagd? Also, Kilt is using a different terminology, ie. they phrase it as 'unlocking unstaked tokens', see here.

Yeah I agree, it's a nice chance for changing that for good. I like 'unlocking unstaked tokens', it is clearer.

@gonzamontiel
Copy link
Contributor Author

gonzamontiel commented Aug 3, 2023

Why are we saying 'Unbond' in one case and 'unboard' in another. Shouldn't we make that consistent? It's the same thing afterall @prayagd?

@ebma Yes they are the same, its a typo. @gonzamontiel Can we make it unbonding? I find the KILT phrase too long.

All this time it has been a typo? lol
I see this other issue is connected though, and it's about naming, so I'll resolve this conversation here.

@gonzamontiel gonzamontiel merged commit ddf06d9 into staging Aug 3, 2023
5 checks passed
@gonzamontiel gonzamontiel deleted the 176-show-the-unstaking-tokens branch August 3, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the unstaking tokens
3 participants