feat: token approval #211
Merged
feat: token approval #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # src/components/Asset/Price/index.tsx # src/components/Balance/index.tsx # src/components/Pools/Backstop/Modal/Deposit/Form/index.tsx # src/components/Pools/Backstop/Modal/Withdraw/Form/index.tsx # src/components/Pools/Backstop/index.tsx # src/components/Pools/Swap/AddLiquidity/index.tsx # src/components/Pools/Swap/Overview/index.tsx # src/components/Pools/Swap/WithdrawLiquidity/index.tsx # src/components/Pools/Swap/index.tsx # src/components/Skeleton/index.tsx # src/components/Swap/From/index.tsx # src/components/Swap/Progress/index.tsx # src/components/Swap/To/index.tsx # src/components/Swap/index.tsx # src/constants/cache.ts # src/contracts/NablaAddresses.ts # src/helpers/calc.ts # src/hooks/useBalance.ts # src/hooks/useContract.ts
|
We could potentially merge this into staging as it only touches nabla even though it's incomplete until the contracts start working |
gonzamontiel
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Overall approved.
There are still some error handling to improve (as discussed) and code that could be reused and it's duplicated (for example in the Swap modals).
Some components could be extracted and used in another parts of the code (like the To and From inputs, the asset selector, etc.).
I appreciate the overall effort, thanks.
Also, thanks for addressing the naming changes I requested.
ebma
pushed a commit
that referenced
this pull request
Aug 24, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-08-24) ### Bug Fixes * lint issues ([#191](#191)) ([fd128e4](fd128e4)) * release ([#236](#236)) ([ce34996](ce34996)) * release ([#238](#238)) ([0fd823b](0fd823b)) * table heading overlap ([#202](#202)) ([061373f](061373f)) * updated foucoco logo ([#198](#198)) ([21dad82](21dad82)) * wallet connection issues [#204](#204) ([#209](#209)) ([fb7a37c](fb7a37c)) ### Features * balance query ([#205](#205)) ([b3aa210](b3aa210)) * contract hooks ([#233](#233)) ([f338f37](f338f37)) * indexer ([#232](#232)) ([2c58c70](2c58c70)) * redirect on logo click [#178](#178) ([#199](#199)) ([9d42e97](9d42e97)) * token approval ([#211](#211)) ([a4ae2bd](a4ae2bd)) * updated backstop pool ui ([#206](#206)) ([1e23f10](1e23f10)) * wallet connect ([#195](#195)) ([5487296](5487296)) ### Reverts * disable nabla ([#201](#201)) ([2e2fe81](2e2fe81))
gonzamontiel
added a commit
that referenced
this pull request
Oct 31, 2023
* feat: indexer (#232) * feat: indexer * refactor: app data * feat: contract hooks (#233) * refactor: contract hooks * refactor: contract write error log * refactor: updated gas limit * fix: swap info * fix: info * fix: transaction ui * fix: console log * [feat] 220 add nova wallet support to the mobile version of portal (#234) * detect if mobile and add novawallet button * change icon * Add Nova Wallet integration in Talisman modal * Slightly improved account box * Add disclaimer explaining why we don't need to implement these methods. * fix: release (#236) * fix: release (#238) * chore(release): 1.1.0 [skip ci] # [1.1.0](v1.0.0...v1.1.0) (2023-08-24) ### Bug Fixes * lint issues ([#191](#191)) ([fd128e4](fd128e4)) * release ([#236](#236)) ([ce34996](ce34996)) * release ([#238](#238)) ([0fd823b](0fd823b)) * table heading overlap ([#202](#202)) ([061373f](061373f)) * updated foucoco logo ([#198](#198)) ([21dad82](21dad82)) * wallet connection issues [#204](#204) ([#209](#209)) ([fb7a37c](fb7a37c)) ### Features * balance query ([#205](#205)) ([b3aa210](b3aa210)) * contract hooks ([#233](#233)) ([f338f37](f338f37)) * indexer ([#232](#232)) ([2c58c70](2c58c70)) * redirect on logo click [#178](#178) ([#199](#199)) ([9d42e97](9d42e97)) * token approval ([#211](#211)) ([a4ae2bd](a4ae2bd)) * updated backstop pool ui ([#206](#206)) ([1e23f10](1e23f10)) * wallet connect ([#195](#195)) ([5487296](5487296)) ### Reverts * disable nabla ([#201](#201)) ([2e2fe81](2e2fe81)) * fix loading in claiming steps (#245) * 145 Show connected accounts token wise breakdown on the dashboard (#240) * Add portfolio table with mock data (WIP) * color change according to new palette * show balance and price for spacewalk assets * improve types in fetcher * comment out mexc api call to stop errors * add USDT to XCM * helper function to add the suffix for wrapped tokens * remove mock data and fetch actual prices and balances * yarn lint fix * Add icons * add total balance * Fix 'DOT' shown instead of 'KSM' on Amplitude * Fix typos * Update src/hooks/usePriceFetcher.ts Co-authored-by: Marcel Ebert <[email protected]> * fix amounts formatting * reduce font and icon size * use dia for PEN token --------- Co-authored-by: Marcel Ebert <[email protected]> * fix remove indicator (#252) * Update design for Spacewalk Issue and Redeeem (#253) * extract base Form component * separate issue and redeem in folders and use new From input * extract feebox and dialog from issue * issue box restyling with collapsible boxes * fix collapsible styles * tweak asset selector to match designs * move coin icons to shared * mock disclaimer text * remove typo * add stellar logo for tab * fix pen/ampe logos and colors * fixes * settings dialog (wip) * add 'back to stellar' design * yarn lint fix * Add settings Dialog * improve from component * improve settings * Update src/components/Layout/links.tsx * rename hook * remove unused spacewalk app * fix tricky dropdown issue not closing on blur * improve settings dialog * improve collapsible behavior * make tabs slightly bigger * invert buttons order * remove minimum * extract useBalances hook * extract get asset display name * fix redeem validation and max tokens * make balance reload when balances hook is ready * max issuable tokens * fix typo * fix showing errors * add missing dot * remove unused code * show errors according to the design * style: 223 update pendulum spacewalk transfers page design (#271) * extract base Form component * separate issue and redeem in folders and use new From input * extract feebox and dialog from issue * issue box restyling with collapsible boxes * fix collapsible styles * tweak asset selector to match designs * move coin icons to shared * mock disclaimer text * remove typo * add stellar logo for tab * fix pen/ampe logos and colors * fixes * settings dialog (wip) * add 'back to stellar' design * yarn lint fix * Add settings Dialog * improve from component * improve settings * Update src/components/Layout/links.tsx * rename hook * remove unused spacewalk app * fix tricky dropdown issue not closing on blur * improve settings dialog * improve collapsible behavior * make tabs slightly bigger * invert buttons order * remove minimum * extract useBalances hook * extract get asset display name * fix redeem validation and max tokens * make balance reload when balances hook is ready * apply new design table colors * include pagination & styles in Table component * fix general styling of Table, fix portfolio table * chore(release): 1.1.1 [skip ci] ## [1.1.1](v1.1.0...v1.1.1) (2023-10-18) * fix: remove irrelevant info from UI (#273) * do not show banner and remove component * fix warning about css nesting * remove versions from sidebar * chore(release): 1.1.2 [skip ci] ## [1.1.2](v1.1.1...v1.1.2) (2023-10-18) ### Bug Fixes * remove irrelevant info from UI ([#273](#273)) ([f8e3a5e](f8e3a5e)) * feat: redirect zenlink menu item only on amplitude (#274) * make Zenlink AMM point to external website * only show on Amplitude * chore(release): 1.2.0 [skip ci] # [1.2.0](v1.1.2...v1.2.0) (2023-10-18) ### Features * redirect zenlink menu item only on amplitude ([#274](#274)) ([4491e6c](4491e6c)) * Update CHANGELOG.md (#276) Update changelog * fix: Show vaults for selected asset on Bridge Settings (#278) * add a context at the parent bridge level to store selected asset * update yarn lock * chore: fix release, upgrade yarn (#280) * chore: fix release, upgrade yarn * fix: missing yarn file * fix: release (#281) * fix: release * fix: github action * chore: updated release config * chore(release): 1.2.1 [skip ci] ## [1.2.1](v1.2.0...v1.2.1) (2023-10-31) ### Bug Fixes * github action ([0b9f207](0b9f207)) * release ([5ebfd88](5ebfd88)) * Show vaults for selected asset on Bridge Settings ([#278](#278)) ([62037d7](62037d7)) * revert: release config --------- Co-authored-by: semantic-release-bot <[email protected]> --------- Co-authored-by: Nejc <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Marcel Ebert <[email protected]>
gonzamontiel
added a commit
that referenced
this pull request
Dec 5, 2023
* feat: indexer (#232) * feat: indexer * refactor: app data * feat: contract hooks (#233) * refactor: contract hooks * refactor: contract write error log * refactor: updated gas limit * fix: swap info * fix: info * fix: transaction ui * fix: console log * [feat] 220 add nova wallet support to the mobile version of portal (#234) * detect if mobile and add novawallet button * change icon * Add Nova Wallet integration in Talisman modal * Slightly improved account box * Add disclaimer explaining why we don't need to implement these methods. * fix: release (#236) * fix: release (#238) * chore(release): 1.1.0 [skip ci] # [1.1.0](v1.0.0...v1.1.0) (2023-08-24) ### Bug Fixes * lint issues ([#191](#191)) ([fd128e4](fd128e4)) * release ([#236](#236)) ([ce34996](ce34996)) * release ([#238](#238)) ([0fd823b](0fd823b)) * table heading overlap ([#202](#202)) ([061373f](061373f)) * updated foucoco logo ([#198](#198)) ([21dad82](21dad82)) * wallet connection issues [#204](#204) ([#209](#209)) ([fb7a37c](fb7a37c)) ### Features * balance query ([#205](#205)) ([b3aa210](b3aa210)) * contract hooks ([#233](#233)) ([f338f37](f338f37)) * indexer ([#232](#232)) ([2c58c70](2c58c70)) * redirect on logo click [#178](#178) ([#199](#199)) ([9d42e97](9d42e97)) * token approval ([#211](#211)) ([a4ae2bd](a4ae2bd)) * updated backstop pool ui ([#206](#206)) ([1e23f10](1e23f10)) * wallet connect ([#195](#195)) ([5487296](5487296)) ### Reverts * disable nabla ([#201](#201)) ([2e2fe81](2e2fe81)) * fix loading in claiming steps (#245) * 145 Show connected accounts token wise breakdown on the dashboard (#240) * Add portfolio table with mock data (WIP) * color change according to new palette * show balance and price for spacewalk assets * improve types in fetcher * comment out mexc api call to stop errors * add USDT to XCM * helper function to add the suffix for wrapped tokens * remove mock data and fetch actual prices and balances * yarn lint fix * Add icons * add total balance * Fix 'DOT' shown instead of 'KSM' on Amplitude * Fix typos * Update src/hooks/usePriceFetcher.ts Co-authored-by: Marcel Ebert <[email protected]> * fix amounts formatting * reduce font and icon size * use dia for PEN token --------- Co-authored-by: Marcel Ebert <[email protected]> * fix remove indicator (#252) * Update design for Spacewalk Issue and Redeeem (#253) * extract base Form component * separate issue and redeem in folders and use new From input * extract feebox and dialog from issue * issue box restyling with collapsible boxes * fix collapsible styles * tweak asset selector to match designs * move coin icons to shared * mock disclaimer text * remove typo * add stellar logo for tab * fix pen/ampe logos and colors * fixes * settings dialog (wip) * add 'back to stellar' design * yarn lint fix * Add settings Dialog * improve from component * improve settings * Update src/components/Layout/links.tsx * rename hook * remove unused spacewalk app * fix tricky dropdown issue not closing on blur * improve settings dialog * improve collapsible behavior * make tabs slightly bigger * invert buttons order * remove minimum * extract useBalances hook * extract get asset display name * fix redeem validation and max tokens * make balance reload when balances hook is ready * max issuable tokens * fix typo * fix showing errors * add missing dot * remove unused code * show errors according to the design * style: 223 update pendulum spacewalk transfers page design (#271) * extract base Form component * separate issue and redeem in folders and use new From input * extract feebox and dialog from issue * issue box restyling with collapsible boxes * fix collapsible styles * tweak asset selector to match designs * move coin icons to shared * mock disclaimer text * remove typo * add stellar logo for tab * fix pen/ampe logos and colors * fixes * settings dialog (wip) * add 'back to stellar' design * yarn lint fix * Add settings Dialog * improve from component * improve settings * Update src/components/Layout/links.tsx * rename hook * remove unused spacewalk app * fix tricky dropdown issue not closing on blur * improve settings dialog * improve collapsible behavior * make tabs slightly bigger * invert buttons order * remove minimum * extract useBalances hook * extract get asset display name * fix redeem validation and max tokens * make balance reload when balances hook is ready * apply new design table colors * include pagination & styles in Table component * fix general styling of Table, fix portfolio table * chore(release): 1.1.1 [skip ci] ## [1.1.1](v1.1.0...v1.1.1) (2023-10-18) * fix: remove irrelevant info from UI (#273) * do not show banner and remove component * fix warning about css nesting * remove versions from sidebar * chore(release): 1.1.2 [skip ci] ## [1.1.2](v1.1.1...v1.1.2) (2023-10-18) ### Bug Fixes * remove irrelevant info from UI ([#273](#273)) ([f8e3a5e](f8e3a5e)) * feat: redirect zenlink menu item only on amplitude (#274) * make Zenlink AMM point to external website * only show on Amplitude * chore(release): 1.2.0 [skip ci] # [1.2.0](v1.1.2...v1.2.0) (2023-10-18) ### Features * redirect zenlink menu item only on amplitude ([#274](#274)) ([4491e6c](4491e6c)) * Update CHANGELOG.md (#276) Update changelog * fix: Show vaults for selected asset on Bridge Settings (#278) * add a context at the parent bridge level to store selected asset * update yarn lock * chore: fix release, upgrade yarn (#280) * chore: fix release, upgrade yarn * fix: missing yarn file * fix: release (#281) * fix: release * fix: github action * chore: updated release config * chore(release): 1.2.1 [skip ci] ## [1.2.1](v1.2.0...v1.2.1) (2023-10-31) ### Bug Fixes * github action ([0b9f207](0b9f207)) * release ([5ebfd88](5ebfd88)) * Show vaults for selected asset on Bridge Settings ([#278](#278)) ([62037d7](62037d7)) * revert: release config --------- Co-authored-by: semantic-release-bot <[email protected]> * revert: Put back GH_TOKEN into the release config (#282) * feat: nabla UI and functionality (#279) * style: updated tables * feat: token out amount * fix: undefined check * Add `decimals` parameter to number conversion functions * fix: balance fetching * fix: decimal point * feat: refetch pools on changes * feat: backstop pool redeem * feat: token price * feat: updates * chore: yarn * refactor: updated info * feat: swap ui * refactor: restrict nabla access to dev * fix: navigation * fix: app env blocking * refactor: updated nav to better handle link visibility --------- Co-authored-by: Marcel Ebert <[email protected]> * feat: added pool filtering by paused flag (#289) * Import from preact/compat (#294) * feat: Add AMPE price to the Dashboard (#293) * add hook to fetch AMPE price * fetch AMPE price correctly * revert conflict and use preact/compat (as the rest of the app) * Update src/hooks/usePriceFetcher.ts * feat: Add info to the Bedeem from Backstop pool UI (#291) * feat: backstop pool withdraw info * refactor: fee * feat: token price on redeem ui --------- Co-authored-by: Gonza Montiel <[email protected]> * no-release: Add GPL LICENSE (#304) Add GPL License * feat: Update transfer dialogs design (#295) * update yarn lock * change date format * general dialogs improvements * completed dialog * update cancelled dialog * update Pending dialog * revert testing change * fix extract colors to css * fix linting & ts errors * revert daiysi ui upgrade * force white color * corrected texts * feat: 288 allow users to withdraw from backstop pool in other assets (#292) * feat: backstop pool withdraw info * refactor: fee * feat: token price on redeem ui * feat: backstop poll withdraw in other assets * fix: removed orig files * fix: removed orig file * fix: types * feat: backstop pool withdraw * style: updated backstop pool ui * feat: pool withdraw * refactor: removed todo * fix: tests * style: swap ui update * style: swap table ui update * style: updated withdraw UI * fix account dropdown (#307) * feat: Update Spacewalk dialogs for "Back to Stellar" transactions (#305) * update yarn lock * change date format * general dialogs improvements * completed dialog * update cancelled dialog * update Pending dialog * revert testing change * fix extract colors to css * fix linting & ts errors * revert daiysi ui upgrade * force white color * corrected texts * move styles to more appropriate file * update designs for back to stellar dialogs * add asset suffix to "Completed" dialog * fix: Update disclaimer text for Spacewalk (#303) * add disclaimer text * Update src/pages/bridge/Issue/index.tsx Co-authored-by: Marcel Ebert <[email protected]> * update disclaimer text with on chain real values --------- Co-authored-by: Marcel Ebert <[email protected]> * feat: Add support for NGN, EUR and AUD assets for Spacewalk (#302) * Add asset icons for bridged and unbridged tokens for spacewalk * add prices to show bridged tokens in the portfolio --------- Co-authored-by: Nejc <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Marcel Ebert <[email protected]> Co-authored-by: gianfra-t <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.