-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icebox] Implement basic nabla communication logic using hard coded contract addresses #197
Closed
ebma
wants to merge
13
commits into
staging
from
196-implement-basic-nabla-communication-logic-using-hard-coded-contract-addresses
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for rococo-souffle-a625f5 failed.
|
ebma
force-pushed
the
196-implement-basic-nabla-communication-logic-using-hard-coded-contract-addresses
branch
from
June 26, 2023 16:36
313d992
to
601bcfa
Compare
ebma
changed the title
Implement basic nabla communication logic using hard coded contract addresses
[Icebox] Implement basic nabla communication logic using hard coded contract addresses
Jun 26, 2023
Closing this now because we now have the indexer available. |
nejcm
deleted the
196-implement-basic-nabla-communication-logic-using-hard-coded-contract-addresses
branch
August 29, 2023 05:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on hold. The idea was to try and implement the smart contract communication already without an indexer so we can make this work before the Decoded conference takes place. However, there are too many outstanding tasks, and the design of the Nabla components is only really viable with the Pendulum theme at the moment. I will keep this PR open because some of the implemented code changes might be useful eventually.
So far I only really managed to fetch some info about pools from the smart contracts on-chain.
The UI elements need to get some tuning, especially since some backgrounds and font colors don't really work well together.
The
nabla-contract-addresses.json
file contains some items with extra...Meta
. This is used to have fewer queries in the app itself. Although this meta info could be fetched from the smart contract itself without problems.Closes #196.