170 add update increment rewards option for staking #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ebma
reviewed
Jun 8, 2023
ebma
approved these changes
Jul 14, 2023
gonzamontiel
deleted the
170-add-update-increment-rewards-option-for-staking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've randomly added a title to each collator's cell with all the non-null information such as email/twitter/etc. I did this because the user deserves to know, but besides, bc the display name of some of them was a hexadecimal string. Taking into account that others are normally shown, I assumed in those cases there was an error on their end (i.e. when calling the Identity pallet), and the title helps identify the collator name better (see attached screenshot)
I didn't call the extrinsic on wallet connect, because I realize the extrinsic is called by the user, and he/she would have to sign, and pay fees. And it's simply horrible UX to do this without user action.
Closes Add Update / Increment rewards option for staking #170