Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(selectors): Extract selectors from daemonsets if not provided through config #33

Merged
merged 5 commits into from
Sep 23, 2024
Merged

feat(selectors): Extract selectors from daemonsets if not provided through config #33

merged 5 commits into from
Sep 23, 2024

Conversation

scoquelin
Copy link
Contributor

@scoquelin scoquelin commented Aug 22, 2024 •
edited
Loading

This allows to retrieve selectors directly from the daemon sets when NodeSelector has not been provided in config.

However, when NodeSelector is provided through config, it will take precedence over retrieving selectors from daemon sets directly.

  • add unit tests
  • add logic to extract selectors from daemonsets
  • adjust RBAC to allow listing daemonsets
  • update documentation
  • small refactoring in calculateTaints to remove previous logic based on continue

Closes #1

@scoquelin scoquelin marked this pull request as draft August 22, 2024 17:47
@scoquelin scoquelin changed the title Extract selector from daemonsets directly if not provided through config feat : Extract selector from daemonsets directly if not provided through config Aug 22, 2024
@scoquelin scoquelin changed the title feat : Extract selector from daemonsets directly if not provided through config feat(selector) : Extract selector from daemonsets directly if not provided through config Aug 22, 2024
@scoquelin scoquelin changed the title feat(selector) : Extract selector from daemonsets directly if not provided through config feat(selector): Extract selector from daemonsets directly if not provided through config Aug 22, 2024
@scoquelin scoquelin changed the title feat(selector): Extract selector from daemonsets directly if not provided through config feat(selectors): Extract selectors from daemonsets directly if not in config Aug 22, 2024
@scoquelin scoquelin changed the title feat(selectors): Extract selectors from daemonsets directly if not in config feat(selectors): Extract selectors from daemonsets if not provided through config Aug 22, 2024
@scoquelin scoquelin force-pushed the match-daemonset-selector branch 2 times, most recently from 1f724ad to ac5366e Compare August 23, 2024 16:19
@scoquelin scoquelin marked this pull request as ready for review September 3, 2024 18:02
@scoquelin scoquelin requested review from chomatdam and josmo and removed request for chomatdam September 3, 2024 18:03
@scoquelin scoquelin force-pushed the match-daemonset-selector branch from d600e17 to 4ded6d1 Compare September 6, 2024 19:02
@scoquelin scoquelin force-pushed the match-daemonset-selector branch from 4ded6d1 to a8fb012 Compare September 10, 2024 23:16
@scoquelin scoquelin force-pushed the match-daemonset-selector branch from a8fb012 to 19cbff1 Compare September 10, 2024 23:18
@scoquelin
Copy link
Contributor Author

@josmo @chomatdam I would appreciate some feedback on this PR thanks !

@scoquelin scoquelin merged commit dbdb572 into main Sep 23, 2024
3 checks passed
@scoquelin scoquelin deleted the match-daemonset-selector branch September 23, 2024 19:36
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josmo josmo josmo approved these changes

@chomatdam chomatdam Awaiting requested review from chomatdam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upstream Daemonset selector
2 participants
@scoquelin @josmo