Fix issue when listing daemonset pods #19
Merged
+29
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chomatdam
approved these changes
Aug 7, 2024
scoquelin
force-pushed
the
fix-matching-pods
branch
from
db8ce5d
to
125cac1
Compare
scoquelin
force-pushed
the
fix-matching-pods
branch
from
125cac1
to
f9e713f
Compare
|
@chomatdam @josmo added unit test to test the fix and confirm existing issue (test does not pass without the fix in place) I think at this point it would be good to do a minor release after this PR is merged. I noticed that there is a |
|
@scoquelin maybe merging in a separate PR something like that before to get the same style as here for releases with feat/fix/chore |
|
@chomatdam OK so if I understand correctly having this in place would automate the manual process of releasing through Github UI after pushing the tag directly to the git repo ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix this issue where the same pod ref keeps being added to the list of matching pods instead of the ref of each different pod matching the criteria.
Closes #18