Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename & migrate representative_plugin as namespace plugin #1

Merged
merged 27 commits into from
Aug 14, 2023
Merged

Rename & migrate representative_plugin as namespace plugin #1

merged 27 commits into from
Aug 14, 2023

Conversation

justinmayer
Copy link
Contributor

@justinmayer justinmayer commented Aug 8, 2023 •
edited
Loading

khuevu and others added 25 commits May 6, 2014 00:27
@khuevu @justinmayer
add the plugin to extract representative image for article and assign…
0f2e16b 
… to an article's property
@khuevu @justinmayer
change image property name to featured_image
3c270d9
@khuevu @justinmayer
update Readme.md
56e060a
@jkrshw @justinmayer
Update readme. Include BeautifulSoup requirement and usage
142f5ab
@jkrshw @justinmayer
Added Image metadata attribute for article to specify a custom repres…
885dd1d 
…entative image.
@jkrshw @justinmayer
Add unit test for custom image
f2ca681
@jkrshw @justinmayer
Update readme to clarify behaviour of plugin and specifying a custom …
8272550 
…image
@justinmayer
PEP8ifying and wiping out trailing spaces.
3ee1e23
@justinmayer
Featured images could be used among all kinds of pages.
2a510c1
@kernc @justinmayer
Have relevant plugins use all_generators_finalized signal
d90dac8 
clean_summary, read_more_link, representative_image, summary
plugins now use all_generators_finalized signal so as to avoid
issue #314. They fallback to current behavior is said signal is
not yet available.

See also: getpelican/pelican#1616

Closes #314.
@kernc @justinmayer
Make representative_image Py3 compatible
d2f8a1a
@Lucas-C @justinmayer
Fixing import in representative_image plugin - cf. #953
5ab78e9
@pauloxnet @justinmayer
Extract representative images for all article's translations
59748d6
@pauloxnet @justinmayer
Fix format issues in python and markdown files
2691d78
@pauloxnet @justinmayer
Fix #1124 Add options to representative image
e8be7fd
@pauloxnet @justinmayer
Representative Image: Enable also in pages (#1220)
510d3d7 
* Enable Representative Image also for pages
* Add requirements.txt
* Add .vscode to .gitignore
@justinmayer
Rename & convert to namespace plugin filesystem layout
3812d68
@justinmayer
Rename plugin in the code & other improvements
7153843
@justinmayer
Apply Black formatting to the project
b5eb20c
@justinmayer
Remove unneeded six from project
2cb0f4f
@justinmayer
Add pyproject file
9aa413a
@justinmayer
Add code style configuration and dev automation
b3b0b70
@justinmayer
Add GitHub Actions CI workflow
d95d339
@justinmayer
Update README
2868eca
@justinmayer
Add CONTRIBUTING and FUNDING
e637dff
@justinmayer justinmayer mentioned this pull request Aug 8, 2023
Closed
@justinmayer
Copy link
Contributor Author

@schtobia replied to my comment about tests not passing for the Representative Image plugin, even in the monolithic repo, even before any rename/migration-related changes were made, and @schtobia said:

Hmm, it seems there is a problem I could use some help with.

It seems like the register() function is successfully connected on all_generators_finalized, but the registered function is never called, at least in the test environment.

Could you please give me some directions where to look further?

I have never used this plugin, and I'm away from my computer for the next few days. So I am ill-equipped to delve into this topic in detail at the moment.

@khuevu @jkrshw @Murchik @kernc @Lucas-C @pauloxnet: As folks who have contributed to this plugin in the past, might you have a moment to take a look and help @schtobia fix the failing tests? (cc: @avaris also, in case he has a moment)

@avaris
Copy link
Contributor

avaris commented Aug 13, 2023

I pushed a commit to fix the tests. The old version of tests would've never worked with the new signal. It connects the signals but the way tests are configured, it would never hit that signal, tests would need to actually run pelican. But that's not needed and changed the tests to only test the functionality.

However, pelican possibly needs a way to reliably get and set summary. Currently I don't think this plugin would be working "correctly". It's supposed to delete the images from summary but these modifications will not be propagated due to the caching of summary.

@justinmayer
Copy link
Contributor Author

justinmayer commented Aug 14, 2023 •
edited
Loading

@avaris: Many thanks for fixing the tests. Let's create a new issue to track whether Pelican needs a way to get and set summary in a reliable manner.

Many thanks also to @khuevu for creating this plugin, to @schtobia for helping migrate it to its new home, and to all the folks who have contributed to the development of this plugin.

Featured Image: https://github.com/pelican-plugins/featured-image/releases/tag/1.0.0 ✨

@justinmayer justinmayer merged commit ccbd1a3 into main Aug 14, 2023
@justinmayer justinmayer deleted the migrate branch August 14, 2023 08:41
@schtobia
Copy link
Collaborator

Thanks @avaris @justinmayer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@justinmayer @avaris @schtobia @khuevu @jkrshw @kernc @Lucas-C @pauloxnet