Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my Navidrome Music Streaming Egg #12

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

devilAPI
Copy link

@devilAPI devilAPI commented Dec 27, 2024

Description

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • [?] Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. [X ] The egg was exported from the panel

@devilAPI devilAPI changed the title Create README.md Add my Navidrome Music Streaming Egg Dec 27, 2024
"description": "Navidrome Music Server - A lightweight music server for your personal collection.",
"features": null,
"docker_images": {
"devilapi\/navidrome-pterodactyl:latest": "devilapi\/navidrome-pterodactyl:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not allowed. The image must be owned by pelican. So please pr it if it meeds the requirements

"docker_images": {
"devilapi\/navidrome-pterodactyl:latest": "devilapi\/navidrome-pterodactyl:latest"
},
"file_denylist": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Startup script is also not allowed for security reasons.

},
"scripts": {
"installation": {
"script": "mkdir \/mnt\/server\/music",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this I assume the files are in the image. This is not allowed. The install script should download them. The image should only hold pacakges.

"description": "",
"env_variable": "ND_PORT",
"default_value": "4533",
"user_viewable": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this the only needed port then please use the build in SERVER_PORT var

# Navidrome Egg for Pterodactyl
A music Streaming Service as an Pterodactyl Egg

[GitHub Repository](https://github.com/devilAPI/navidrome-music-streaming-pterodactyl-egg).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to the software source. Not where you host your egg.


[GitHub Repository](https://github.com/devilAPI/navidrome-music-streaming-pterodactyl-egg).

Just import it into Pterodactyl, change the "Port" value on the "Startup" page and you're good to go!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the required ports table?

@QuintenQVD0
Copy link
Contributor

Where even is the source code for this bot?

@devilAPI
Copy link
Author

Contributor

its not a bot, its a subsonic server, something like selfhosted spotify.

https://github.com/navidrome/navidrome/tree/master

@QuintenQVD0
Copy link
Contributor

Contributor

its not a bot, its a subsonic server, something like selfhosted spotify.

https://github.com/navidrome/navidrome/tree/master

Thats fine but please read https://github.com/pelican-eggs/software/blob/main/CONTRIBUTING.md and resolve all my comments please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants