-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add ntfy egg #2582
base: master
Are you sure you want to change the base?
Add ntfy egg #2582
Conversation
@QuintenQVD0 Ive added the changes you suggested could you look over it again? |
looks fine to me, just have to test it. |
@ThnksCJ How to we use this as the issue was closed because you like need to change the startup off the egg. so how does this egg handle this as I do not know this aplication |
You can configure the server.yml file that gets created and it's already pre-configured with a working config on the default allocation host and port. You can configure it to add a proxy host and such but you would need to look through the docs for that. If you span up an instance and visited it on http then it would all be working as a basic thing |
@QuintenQVD0 I changed the way the config is made to make it hopefully a bit more user friendly, could you look over it? Thanks 👍🏻 |
@@ -15,14 +15,14 @@ | |||
"file_denylist": [], | |||
"startup": ".\/ntfy serve --config server\/server.yml", | |||
"config": { | |||
"files": "{\r\n \"server\/server.yml\": {\r\n \"parser\": \"yaml\",\r\n \"find\": {\r\n \"listen-http\": \":{{server.build.default.port}}\",\r\n \"cache-file\": \".\/cache.db\"\r\n }\r\n }\r\n}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wy did you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because this would only show when the server was started for the first time which I don't think is the best so I moved the server.yml creation into the init script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files run on every startup and should be there as you must force the port it uses, and hard setting the cache db in it is also a good idea. The config just has to be in that place before the server starts for the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I create the file in the init script should I still keep it in the files? I just assumed it would be better as when the user installs the server they don't have to start it to see the configuration file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End users do not see this configuration logic. it is expected that all ports an application uses are locked and users can not change it so they copy a config from somewhere, and it has another port set that it reverts that line back. else host will get flooded with support tickets.
how do you manage users if the startup command is hard coded? |
change the startup in the egg or server, when you are admin? |
why? it would be enough to make the startup like |
I thought users could be added using the web UI and it work the same as using a cmd to do it |
it should indeed, as the user will never be allowed to change the startup themselves in offical eggs. |
how? in the web UI the add user button is only a way to log into users made with |
if that is true, this egg likely will be closed as uses are not allowed to self edit the startup |
I must have overlooked this fact, mabye ntfy won't work as an egg after all |
can't it be done like so? |
That would be better but is almost the same as just giving the user direct startup asses as you put a ; and the command and the panel will run it. |
Doesn't the nodejs egg do something like that to start the main file? Wouldn't you be able to put a ; and it escape too |
yes technically yes, but that variable is locked to a max of 64 char and should (it is not) be locked with alpha_dash rule what as it sas only allows letters and _ and not symbols. |
Then could you not do the same on this egg? Or would that raise password security issues |
Problem is it does not allow for |
@ThnksCJ Can an admin used create other users on the web interface or is it all command line interface, else we just create 1 stock user. seems like larvel 10 allowed - so |
From what i have read it all has to be done using the cli which is an issue, that is to create specific channels locked behind authentication. Not sure how we could overcome this issue without making a custom image that has a shell to accept commands or somehting |
That wont be happening. |
found out in the enable-signup: true # anyone can create an account through the web ui
enable-login: true # anyone can login into accounts through the web ui using user and pass
enable-reservations: true # anyone can reserve topics for themselves only limit is you can't choose who can make accounts and who can't, or who can reserve and who can't however technically you can if you enable these settings only when you want to create an account or manage reserved topics and disable when you don't need to |
its even yaml so you could add variable for those nad let the config parser turn them on and off |
Description
Ntfy is a simple HTTP-based pub-sub notification service. It allows you to send notifications to your phone or desktop via scripts from any computer, and/or using a REST API.
Closed issue requesting ntfy: #2471
Checklist for all submissions
New egg Submissions