Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile + Layout Changes #836

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Mobile + Layout Changes #836

wants to merge 13 commits into from

Conversation

notAreYouScared
Copy link
Member

Server Overview - Desktop
image

Server Overview - Mobile
image

View Schedules - Mobile ( Before )
image
View Schedules - Mobile ( After )
image

Edit Schedules - Mobile ( Before )
image
Edit Schedules - Mobile ( After )
image

@TekExplorer
Copy link
Contributor

TekExplorer commented Dec 21, 2024

Consider having the line only consider the usage numbers, and not the tile for the section. This feels like the line is over-reaching.
image

In most cases, where the contents extend larger than the word, you wont notice, but it would be especially noticeable in translated languages where the word may be particularly long, which may result in comically long lines that just feel bad
-- in my opinion

Copy link
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, we'll need to work together to figure out the phpstan issues so we're not just adding @phpstan-ignore's everywhere!

@pelican-dev pelican-dev deleted a comment from notAreYouScared Dec 24, 2024
@notAreYouScared
Copy link
Member Author

@lancepioch Your changes broke displaying the limit, if it's not unlimited, it just shows 0...

Also removed the functionally of GiB vs GB both options show GB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants