Fix trusted proxies settings & Move ips to config & Add ipv6 #692
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notAreYouScared
approved these changes
Oct 29, 2024
lancepioch
previously requested changes
Oct 29, 2024
|
Should i make it pull regularly or leave it to only manual via Settings ? |
Only manual, there is no reason to pull it regulalry.
No, it's fine. But remove the service. That's unnecessary. |
Boy132
requested changes
Oct 31, 2024
Boy132
approved these changes
Nov 1, 2024
notAreYouScared
dismissed
lancepioch’s stale review
Changes requested were made.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to
config('trustedproxy.proxies')being a string so you have to implode it otherwise it will put a blank string in by default