Deprecate importVenues
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is safe to merge, but we've already had one breaking change release today, maybe we hold off until next week? If people report issues trying to download venues then we should merge this, but otherwise it's not urgent. |
BREAKING CHANGE: Because we do not expect Who's on First to update venue data, and we will likely never publish that data to the new data host from Geocode Earth, the `importVenues` option is now deprecated. Connects #94
orangejulius
force-pushed
the
deprecate-importVenues
branch
from
98ff8a9 to
68a3f52
Compare
orangejulius
added a commit
to pelias-deprecated/kubernetes
that referenced
this pull request
Aug 13, 2020
This flag was deprecated in pelias/whosonfirst#503, and is no longer allowed in `pelias.json`
This was referenced Sep 23, 2020
raduachim
pushed a commit
to Iteam1337/predictivemovement
that referenced
this pull request
Jan 19, 2021
raduachim
added a commit
to Iteam1337/predictivemovement
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Because we do not expect Who's on First to update venue data, and we will likely never publish that data to the new data host from Geocode Earth, the
importVenuesoption is now deprecated.Connects #94