Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a dockerfile for upstream tool builds #2

Open
wants to merge 1 commit into
base: peek-master
Choose a base branch
from
Open

add a dockerfile for upstream tool builds #2

wants to merge 1 commit into from

Conversation

bgroupe
Copy link
Member

@bgroupe bgroupe commented Oct 27, 2021

No description provided.

@bgroupe bgroupe requested a review from martInatpeek October 27, 2021 23:13
martInatpeek
martInatpeek approved these changes Oct 28, 2021
View reviewed changes
Copy link

@martInatpeek martInatpeek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest insomnia master should have most of the issues that pushed us to fork their repo fixed (mocha timeout and chaining of request).
updating at some point would simplify this dockerFile a lot.

@martInatpeek
Copy link

also one tweak that was done in our version of inso-cli was to add the option to list the test suite available.
If not needed we could pretty much use latest inso-cli from npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martInatpeek martInatpeek martInatpeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgroupe @martInatpeek