Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures because of times with microseconds #299

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

brianberlin
Copy link
Contributor

@brianberlin brianberlin commented Sep 12, 2023

connect #297

What

Makes use of new helper function that wraps Timex shift functions but also truncates microseconds precision.

Why

Timex.shift/2 adds microsecond precision to datetimes

Reference to issue in Timex: bitwalker/timex#731

@brianberlin brianberlin self-assigned this Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (988bd3d) 96.52% compared to head (4a56057) 96.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   96.52%   96.55%   +0.02%     
==========================================
  Files          21       21              
  Lines         489      493       +4     
==========================================
+ Hits          472      476       +4     
  Misses         17       17              
Files Changed Coverage Δ
lib/cocktail/builder/i_calendar.ex 97.14% <ø> (ø)
lib/cocktail/validation/interval.ex 100.00% <ø> (ø)
lib/cocktail/schedule_state.ex 100.00% <100.00%> (ø)
lib/cocktail/util.ex 100.00% <100.00%> (ø)
lib/cocktail/validation/day_of_month.ex 94.73% <100.00%> (ø)
lib/cocktail/validation/schedule_lock.ex 100.00% <100.00%> (ø)
lib/cocktail/validation/shift.ex 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianberlin brianberlin changed the title Truncates milliseconds wherever timex shift is used Fix test failures because of times with microseconds Sep 12, 2023
@brianberlin brianberlin force-pushed the 297-milliseconds branch 2 times, most recently from 42d0ff0 to 92155c5 Compare September 14, 2023 15:31
@brianberlin brianberlin merged commit 230963f into main Sep 22, 2023
12 checks passed
@brianberlin brianberlin deleted the 297-milliseconds branch September 22, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants