Merge Partial Resolve 18 Support #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eb52d8a. Doesn't seem to have any effect. Will leave it for now.
These opinionated bugbear rules are not implemented in Ruff yet: - B950 (line too long), using equivalent: E501. - B902 (invalid first arg for method), using equivalent: N804, N805 See: astral-sh/ruff#2954 These pycodestyle rules are not implemented in Ruff yet and have no equivalent rules: - E303 (too many blank lines), - E302 (Expected 2 blank lines, found 0) - E301 (Expected 1 blank line, found 0) Previously ignored for "pydavinci/wrappers/settings/components.py". Since they don't exist, we don't need to ignore them, but this will apply package wide. Black should handle formatting these correctly anyway.
Black already handles trailing whitespace and newlines at EOF.
- Format changes with Black - Upgrade syntax with PyUpgrade - TYPE_CHECKING block checks with Ruff TCH - Add missing type annotations per MyPy errors
Before now API support for galleries was incomplete. Most of the return values were the wrong types, etc. (my bad) I changed some things too. Getting and setting the name from the Gallery object instead of as a property of the GalleryStillAlbum seemed obtuse. So I took inspiration from the MarkerCollection object and added the parent object into all the function calls for GalleryStillAlbum. I did a similar thing with gallery stills to more easily get and set their labels. See TODO comments for more info. These changes are untested. Further changes are likely required.
…ng-timeline-timecode-property-setter
PR: Update latest changes from in03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an ongoing discussion on issue #42, we've decided to merge existing partial Resolve 18 support from the
resolve_18branch and tentatively pursue coverage of Resolve 19.