Allow user specify fn for .pipe which returns something but doesn't p…

…rovide
pedrokehl · Mar 5, 2024 · 0111404 · 0111404
1 parent 66f08d7
commit 0111404
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/benchmark/subFlow.benchmark.ts b/benchmark/subFlow.benchmark.ts
@@ -18,7 +18,7 @@ async function runSubflowBenchmark(parentItems: number, childItemsPerParent: num
     .reduce({ fn: steps.accumulatorFn, seed: 0, provides: 'count' })
 
   const parentCaminho = from(steps.parentGenerator, { maxItemsFlowing: 1_000 })
-    .pipe({ fn: steps.pipeFn, provides: 'pipe1' })
+    .pipe({ fn: steps.pipeFn })
     .pipe({ fn: (bag: ValueBag) => childCaminho.run(bag, ['count']), provides: 'child' })
     .reduce({
       fn: (acc: number, bag: ValueBag) => acc + bag.child.count,

diff --git a/src/operators/batch.ts b/src/operators/batch.ts
@@ -13,14 +13,12 @@ interface BaseBatchParams {
     timeoutMs: number
   }
   maxConcurrency?: number
-}
-export interface BatchParamsProvides extends BaseBatchParams {
   fn: (valueBag: ValueBag[]) => unknown[] | Promise<unknown[]>
-  provides: string
 }
 
-export interface BatchParamsNoProvides extends BaseBatchParams {
-  fn: (valueBag: ValueBag[]) => void | Promise<void>
+export type BatchParamsNoProvides = BaseBatchParams
+export interface BatchParamsProvides extends BaseBatchParams {
+  provides: string
 }
 
 export function batch(params: BatchParams, loggers: Loggers): OperatorApplier {

diff --git a/src/operators/pipe.ts b/src/operators/pipe.ts
@@ -8,17 +8,14 @@ export type PipeParams = PipeParamsProvides | PipeParamsNoProvides
 interface BasePipeParams {
   name?: string
   maxConcurrency?: number
+  fn: (valueBag: ValueBag) => unknown | Promise<unknown>
 }
 
+export type PipeParamsNoProvides = BasePipeParams
 export interface PipeParamsProvides extends BasePipeParams {
-  fn: (valueBag: ValueBag) => unknown | Promise<unknown>
   provides: string
 }
 
-export interface PipeParamsNoProvides extends BasePipeParams {
-  fn: (valueBag: ValueBag) => void | Promise<void>
-}
-
 export function pipe(params: PipeParams, loggers: Loggers): OperatorApplier {
   const getBag = pipeHasProvides(params) ? valueBagGetterProvides(params.provides) : valueBagGetterNoProvides()