This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Add kubernetes support #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @stevemcquaid, for sure I'm open to receive PR's o the repo. I just think we trully need to brake it in smaller changes. For instance, the Dockerfile that creates the Grafana and the Speedtest image are keep in a different branch (because we have an automated build created on Dockerhub that identify every change on that branch and create a new Docker image). I think the first work would be find out the best approach to merge everything together and keep that working. As soon as I can, I'm gonna have a look and let you know. Thank you for you availability to help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am happy to break this PR up into smaller chunks - but figured I'd submit something to see if you are open to the idea + to receive feedback.
Love the project, let me know if I can help!