Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several additions/improvements #65

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dkden7e
Copy link
Contributor

@dkden7e dkden7e commented Jul 3, 2022

  • More options to remove/wear toggles (dkden7e@da161cb).
  • Filter tattoos by gender (only show the ones that work for each gender) (dkden7e@953f4ec & dkden7e@97a8207).
  • Alternate makeup base color (dkden7e@a47e80b). I haven't tested if the existing one works properly (it looks like an incomplete adaptation of my original contribution to old Overexteded's fork -dkden7e/fivem-appearance-ox_old@93a7167 -, could be a coincidence tho and there's no problem in any case), this version is tested and should work for all purposes and under all circumstances.
  • Alternate ES locale (several commits).

dkden7e and others added 8 commits July 3, 2022 14:51
@franfdezmorales
Copy link
Collaborator

Hey, the pr is fine, also, i would like to add that i didnt filter the tattoos by gender bc are the same, the only thing that changes is the size and some people could prefer the small option, maybe u could add a convar to filter tattoos if someone want to activate the feature?

Really ty for ur time!

@dkden7e
Copy link
Contributor Author

dkden7e commented Jul 7, 2022

i didnt filter the tattoos by gender bc are the same, the only thing that changes is the size and some people could prefer the small option

Hi, the filter only hides tattoos that do not exist for the specified gender (so when you select them just nothing happens), tattoos that exist for both genders are always shown.

Thanks for the appreciation! (and nice job too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants