-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial low Mach reacting flow capabilities #281
Commits on Jun 4, 2024
-
initial commit of reacting species dev branch
* rough skeleton of new features added but nothign hooked up * added mixture, transport, and chemistry instantiation in reactingFlow constructor * added rx to assert check:
Configuration menu - View commit details
-
Copy full SHA for 34537a0 - Browse repository at this point
Copy the full SHA 34537a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d9c45 - Browse repository at this point
Copy the full SHA 69d9c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for d56dffa - Browse repository at this point
Copy the full SHA d56dffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b76486 - Browse repository at this point
Copy the full SHA 6b76486View commit details -
* runs but temp does not converge in first step * valgrind errors galore
Configuration menu - View commit details
-
Copy full SHA for b122d64 - Browse repository at this point
Copy the full SHA b122d64View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3e41e6 - Browse repository at this point
Copy the full SHA d3e41e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a9c71 - Browse repository at this point
Copy the full SHA 80a9c71View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb4bfe - Browse repository at this point
Copy the full SHA ddb4bfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8405e03 - Browse repository at this point
Copy the full SHA 8405e03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3122fe9 - Browse repository at this point
Copy the full SHA 3122fe9View commit details -
fixed Cp bug on explicit unsteady terms in temp, resT useage in speci…
…es, and Rgas init error
Configuration menu - View commit details
-
Copy full SHA for 871a9ec - Browse repository at this point
Copy the full SHA 871a9ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bd2ceb - Browse repository at this point
Copy the full SHA 3bd2cebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 382aa6c - Browse repository at this point
Copy the full SHA 382aa6cView commit details -
fixes (i think) to species and mixture Cp, seems to still have a prob…
…lem with production
Configuration menu - View commit details
-
Copy full SHA for 0fd58b9 - Browse repository at this point
Copy the full SHA 0fd58b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9d118f - Browse repository at this point
Copy the full SHA d9d118fView commit details -
Fix bug in ReactingFlow::speciesProduction
The primitive state was being filled with mass fractions for the species entries and then passed to GetConservativesFromPrimitives, but this function expects that the species entries of the primitive state contain molar densities. Because of this, the returned conserved state was incorrect and the resulting molar densities returned by computeNumberDensities were also incorrect, which then made the species production terms incorrect.
Configuration menu - View commit details
-
Copy full SHA for 394fcf8 - Browse repository at this point
Copy the full SHA 394fcf8View commit details -
Bug fixes in ReactingFlow::heatOfFormation
Three bug fixes here: 1) The units of the formation energy from the input file is J / mol, so we need to divide by the species weight (kg / mol) here to get the formation energy per unit mass. 2) The vector hw_ was sizes to have entries for all species and the contributions were not summed. We need hw_ to be a scalar field with the contributions from all species summed. 3) Sign error Note that this commit does not add the sensible enthalpy contribution (see Poinsot and Veynante, Theoretical and Numerical Combustion, 2005, eq. 1.62).
Configuration menu - View commit details
-
Copy full SHA for 1049b25 - Browse repository at this point
Copy the full SHA 1049b25View commit details -
Bug fix in ReactingFlow::UpdateTimestepHistory
Species history update was out of order.
Configuration menu - View commit details
-
Copy full SHA for 9d1f048 - Browse repository at this point
Copy the full SHA 9d1f048View commit details -
Non-general implementation of sensible enthalpy contribution...
to energy eqn rhs in ReactingFlow::heatOfFormation. Not general b/c Cv is hardcoded. Just for investigation. Don't merge this.
Configuration menu - View commit details
-
Copy full SHA for 60dcead - Browse repository at this point
Copy the full SHA 60dceadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe8dfe - Browse repository at this point
Copy the full SHA 1fe8dfeView commit details -
removed passing of full state to getCp routines and fixed a couple in…
…t vs full dof bugs
Configuration menu - View commit details
-
Copy full SHA for c488b02 - Browse repository at this point
Copy the full SHA c488b02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a53911 - Browse repository at this point
Copy the full SHA 5a53911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f834f - Browse repository at this point
Copy the full SHA 23f834fView commit details -
Three bugs were found and fixed while working on the low Mach analog to argon_minimal.binary.test. The fixes are 1) In ReactingFlow::speciesStep, set the initial guess for the iterative linear solve to the mass fraction for the current species from the previous time step. Because of how Yn_next_gf_ is managed, that was not the case and sometimes the electron species solve in particular struggled because of it. 2) Multiply the diffusivities returned by computeMixtureAverageDiffusivity by the mixture density (i.e., so that the diffision term in the species equation is div( \rho D \grad Y) ). 3) Populate the species entries of the primitive state in ReactingFlow::updateDiffusivity with the mole densities, rather than the mass fraction.
Configuration menu - View commit details
-
Copy full SHA for 916de16 - Browse repository at this point
Copy the full SHA 916de16View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce47b0d - Browse repository at this point
Copy the full SHA ce47b0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b462b - Browse repository at this point
Copy the full SHA d5b462bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 601dc90 - Browse repository at this point
Copy the full SHA 601dc90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bbd569 - Browse repository at this point
Copy the full SHA 0bbd569View commit details -
Update input file for reactFlow-binDiff.test
Two mods: 1) Set velocity to 0. Because of a bug, the test was generated with 0 velocity rather than what the input file said. 2) Tighten linear solver tolerance.
Configuration menu - View commit details
-
Copy full SHA for c121419 - Browse repository at this point
Copy the full SHA c121419View commit details -
Relax tolerance on LeQuere test
Was always too tight. Bug fix in LQ_form_ DiffusionIntegrator coefficient in CaloricallyPerfectThermoChem was enough to push it past tolerance. Given linear solver tolerances, updated values seem reasonable.
Configuration menu - View commit details
-
Copy full SHA for b0b9b97 - Browse repository at this point
Copy the full SHA b0b9b97View commit details -
Relax tolerance in reactFlow-binDiff.test
Need to check with shaering about this.
Configuration menu - View commit details
-
Copy full SHA for 22b2051 - Browse repository at this point
Copy the full SHA 22b2051View commit details -
Workaround for cuda stack sizing issue
It appears that the computeMixtureAverageDiffusivity functions have tripped up the cuda support for virtual functions, as we have encountered prieviously (e.g., #203). For the moment, I hack around the problem by introducing an unused argument in computeMixtureAverageDiffusivity, which makes its signature sufficiently unique that the problem doesn't occur.
Configuration menu - View commit details
-
Copy full SHA for 2acc9fd - Browse repository at this point
Copy the full SHA 2acc9fdView commit details -
Tweak low Mach variant of single reaction test
To more closely match the original compressible path test.
Configuration menu - View commit details
-
Copy full SHA for 27a2e87 - Browse repository at this point
Copy the full SHA 27a2e87View commit details -
Tweak low Mach variant of argon minimal diffusion test
To better match original compressible path test
Configuration menu - View commit details
-
Copy full SHA for 8ebc5cd - Browse repository at this point
Copy the full SHA 8ebc5cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad29ad9 - Browse repository at this point
Copy the full SHA ad29ad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f86f06a - Browse repository at this point
Copy the full SHA f86f06aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d8e0f - Browse repository at this point
Copy the full SHA 28d8e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2fd982 - Browse repository at this point
Copy the full SHA f2fd982View commit details -
Add some checks to low Mach reacting
We don't (yet) support ambipolar (quasi-neutral) or two-temperature on the low Mach reacting path. Die if detected.
Configuration menu - View commit details
-
Copy full SHA for 8998ea7 - Browse repository at this point
Copy the full SHA 8998ea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b1339d - Browse repository at this point
Copy the full SHA 3b1339dView commit details -
fixed bug related to error in tomboulides paper eq 1.1a. Cross-diffus…
…ion term now consistent with Poinsot book eq 1.67.
Configuration menu - View commit details
-
Copy full SHA for 53e9444 - Browse repository at this point
Copy the full SHA 53e9444View commit details -
Configuration menu - View commit details
-
Copy full SHA for cab31b6 - Browse repository at this point
Copy the full SHA cab31b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a1d673 - Browse repository at this point
Copy the full SHA 5a1d673View commit details