Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial low Mach reacting flow capabilities #281

Merged
merged 43 commits into from
Jun 6, 2024
Merged

Commits on Jun 4, 2024

  1. initial commit of reacting species dev branch

    * rough skeleton of new features added but nothign hooked up
    * added mixture, transport, and chemistry instantiation in reactingFlow constructor
    * added rx to assert check:
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    34537a0 View commit details
    Browse the repository at this point in the history
  2. hooked up reactingFlow to grab properties from transport/chemistry, N…

    …OT TESTED
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    69d9c45 View commit details
    Browse the repository at this point in the history
  3. added species diffusion source term in temp eq

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d56dffa View commit details
    Browse the repository at this point in the history
  4. small change to update diffs

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6b76486 View commit details
    Browse the repository at this point in the history
  5. WIP state

    * runs but temp does not converge in first step
    * valgrind errors galore
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b122d64 View commit details
    Browse the repository at this point in the history
  6. switch last Yn to be solved for using other Yn's

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d3e41e6 View commit details
    Browse the repository at this point in the history
  7. temp hard-code for Cp in dPodt term in temp

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    80a9c71 View commit details
    Browse the repository at this point in the history
  8. added Cp to temp eq via op coeffs, not running

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ddb4bfe View commit details
    Browse the repository at this point in the history
  9. fixed some uninit problems and a tmpR0_ misuse

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8405e03 View commit details
    Browse the repository at this point in the history
  10. wip, hard-code CpMix=1 and dtPo=0, temp not stable otherwise

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3122fe9 View commit details
    Browse the repository at this point in the history
  11. fixed Cp bug on explicit unsteady terms in temp, resT useage in speci…

    …es, and Rgas init error
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    871a9ec View commit details
    Browse the repository at this point in the history
  12. added updates to MsRho and MsRhoCp

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3bd2ceb View commit details
    Browse the repository at this point in the history
  13. patterned argon mixture diffusivity off flux mixture flux routine

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    382aa6c View commit details
    Browse the repository at this point in the history
  14. fixes (i think) to species and mixture Cp, seems to still have a prob…

    …lem with production
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0fd58b9 View commit details
    Browse the repository at this point in the history
  15. small fix to reaction rate related data sizes/types

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d9d118f View commit details
    Browse the repository at this point in the history
  16. Fix bug in ReactingFlow::speciesProduction

    The primitive state was being filled with mass fractions for the
    species entries and then passed to GetConservativesFromPrimitives, but
    this function expects that the species entries of the primitive state
    contain molar densities.  Because of this, the returned conserved
    state was incorrect and the resulting molar densities returned by
    computeNumberDensities were also incorrect, which then made the
    species production terms incorrect.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    394fcf8 View commit details
    Browse the repository at this point in the history
  17. Bug fixes in ReactingFlow::heatOfFormation

    Three bug fixes here:
    
    1) The units of the formation energy from the input file is J / mol,
    so we need to divide by the species weight (kg / mol) here to get the
    formation energy per unit mass.
    
    2) The vector hw_ was sizes to have entries for all species and the
    contributions were not summed.  We need hw_ to be a scalar field with
    the contributions from all species summed.
    
    3) Sign error
    
    Note that this commit does not add the sensible enthalpy contribution
    (see Poinsot and Veynante, Theoretical and Numerical Combustion, 2005,
    eq. 1.62).
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1049b25 View commit details
    Browse the repository at this point in the history
  18. Bug fix in ReactingFlow::UpdateTimestepHistory

    Species history update was out of order.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9d1f048 View commit details
    Browse the repository at this point in the history
  19. Non-general implementation of sensible enthalpy contribution...

    to energy eqn rhs in ReactingFlow::heatOfFormation.  Not general b/c
    Cv is hardcoded.  Just for investigation.  Don't merge this.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    60dcead View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    1fe8dfe View commit details
    Browse the repository at this point in the history
  21. removed passing of full state to getCp routines and fixed a couple in…

    …t vs full dof bugs
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c488b02 View commit details
    Browse the repository at this point in the history
  22. adding ic-distribution function for species

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5a53911 View commit details
    Browse the repository at this point in the history
  23. added ic for binary diffusion test case

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    23f834f View commit details
    Browse the repository at this point in the history
  24. Bug fixes in ReactingFlow

    Three bugs were found and fixed while working on the low Mach analog
    to argon_minimal.binary.test.  The fixes are
    
    1) In ReactingFlow::speciesStep, set the initial guess for
    the iterative linear solve to the mass fraction for the current
    species from the previous time step.  Because of how Yn_next_gf_ is
    managed, that was not the case and sometimes the electron species
    solve in particular struggled because of it.
    
    2) Multiply the diffusivities returned by
    computeMixtureAverageDiffusivity by the mixture density (i.e., so that
    the diffision term in the species equation is div( \rho D \grad Y) ).
    
    3) Populate the species entries of the primitive state in
    ReactingFlow::updateDiffusivity with the mole densities, rather than
    the mass fraction.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    916de16 View commit details
    Browse the repository at this point in the history
  25. adding tests for reacting flow

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ce47b0d View commit details
    Browse the repository at this point in the history
  26. enforce style

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d5b462b View commit details
    Browse the repository at this point in the history
  27. trying to get rid of virtual function override intended? warning

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    601dc90 View commit details
    Browse the repository at this point in the history
  28. working through warnings

    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0bbd569 View commit details
    Browse the repository at this point in the history
  29. Update input file for reactFlow-binDiff.test

    Two mods:
    
    1) Set velocity to 0.  Because of a bug, the test was generated with 0
    velocity rather than what the input file said.
    
    2) Tighten linear solver tolerance.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c121419 View commit details
    Browse the repository at this point in the history
  30. Relax tolerance on LeQuere test

    Was always too tight.  Bug fix in LQ_form_ DiffusionIntegrator
    coefficient in CaloricallyPerfectThermoChem was enough to push it past
    tolerance.  Given linear solver tolerances, updated values seem
    reasonable.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b0b9b97 View commit details
    Browse the repository at this point in the history
  31. Relax tolerance in reactFlow-binDiff.test

    Need to check with shaering about this.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    22b2051 View commit details
    Browse the repository at this point in the history
  32. Workaround for cuda stack sizing issue

    It appears that the computeMixtureAverageDiffusivity functions have
    tripped up the cuda support for virtual functions, as we have
    encountered prieviously (e.g., #203).  For the moment, I hack around
    the problem by introducing an unused argument in
    computeMixtureAverageDiffusivity, which makes its signature
    sufficiently unique that the problem doesn't occur.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2acc9fd View commit details
    Browse the repository at this point in the history
  33. Tweak low Mach variant of single reaction test

    To more closely match the original compressible path test.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    27a2e87 View commit details
    Browse the repository at this point in the history
  34. Tweak low Mach variant of argon minimal diffusion test

    To better match original compressible path test
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8ebc5cd View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    ad29ad9 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    f86f06a View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    28d8e0f View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    f2fd982 View commit details
    Browse the repository at this point in the history
  39. Add some checks to low Mach reacting

    We don't (yet) support ambipolar (quasi-neutral) or two-temperature on
    the low Mach reacting path.  Die if detected.
    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8998ea7 View commit details
    Browse the repository at this point in the history
  40. Style

    trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3b1339d View commit details
    Browse the repository at this point in the history
  41. fixed bug related to error in tomboulides paper eq 1.1a. Cross-diffus…

    …ion term now consistent with Poinsot book eq 1.67.
    Sigfried Haering authored and trevilo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    53e9444 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    cab31b6 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    5a1d673 View commit details
    Browse the repository at this point in the history