Add URL slugs to the CloudPebble IDE JavaScript #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on master. |
This adds a simple routing system to the IDE / Project page that allows direct linking to a file or resource, as well as to the settings, compilation, or github panes. This is acclomplished by using the window.location.hash property, and removes some of the burden from the sidebar's javascript for managing the current view state.
Katharine
force-pushed
the
master
branch
2 times, most recently
from
9c24fe0
to
222285f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to go to /ide/projects/:id#settings to get to their project's settings. This adds a new CloudPebble.Locations API that handles the storage of valid slugs and calls a function to activate the proper slugs on the
onhashchangeevent. It also includes a function to set the current slug in the URL.To fix a bug, the Sidebar was disavowed of it's responsibility of resource and source file switching by callback, instead stuffing a valid slug into the
aelement it generates.