Add support for publishedMedia #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacerat
force-pushed
the
feature/publishedMedia
branch
from
bf2eae0
to
185fccd
Compare
* Only replace `{{pkjs_entry_point}}` when `app_modern_multi_js`.
* re-chain replaces
* Don't give json to workers.
Allow running 4.0 apps on applite 3.12.2+
Spacerat
force-pushed
the
feature/publishedMedia
branch
from
185fccd
to
fde158e
Compare
Fix run button widths
PBL-39874 Pressing ENTER resets the app UUID
Correctly check the watch platform.
Support aplite packages.
Spacerat
force-pushed
the
feature/publishedMedia
branch
from
fde158e
to
44f09cf
Compare
Spacerat
force-pushed
the
feature/publishedMedia
branch
from
44f09cf
to
c959dc5
Compare
Fix and test pebblejs resources.
Spacerat
force-pushed
the
feature/publishedMedia
branch
from
c959dc5
to
34e1730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to CloudPebble for publishedMedia.
The basic interface looks like this. It is only available for Native SDK 4 projects (and not packages).
It has the following behaviours:
The form auto-saves whenever it is in a valid state, and it doesn't disrupt the user with errors while editing. If the user isn't sure why the form isn't saving, they will probably try submitting the form by pressing enter or clicking the save button, at which point they will actually be shown an error message which disappears as soon as the user resolves the error.
Only the first item has the help text - the rest look like this:
The "Add New Published Media" button adds a new section, with a numeric ID of max(ids)+1.
When you rename your own project's resource IDs, CloudPebble attempts to figure out what was renamed to what, and then rename the corresponding publishedMedia entry. In 99% of cases (i.e. a resource ID which was unique was renamed to something else) this will be successful.
However, there are a number of possible actions which can result in publishedMedia referencing ResourceIDs which no longer exist, and when this happens an icon will appear next to the sidebar menu
These actions include:
Finally: because it is not possible for CloudPebble to know whether the publishedMedia are valid until it gets the list of resources from dependencies (which happens via the YCM proxy), the pane will not show until YCM has finished (or failed) initialising. If the user navigates to the pane before that, a simple loading message is shown.
