Assume S3 is enabled #298
Open
Assume S3 is enabled #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacerat
force-pushed
the
feature/assume-s3
branch
from
82d8725
to
b06a6b7
Compare
Spacerat
force-pushed
the
feature/assume-s3
branch
from
b06a6b7
to
9e4c696
Compare
|
There's one issue with doing this: it makes it difficult to run any automated tests which do things with files, especially on travis. Tests would end up trying to touch S3, which is OK-ish during local development, but not so good on travis. A simple solution would be to inject a fake S3 during tests which just acts as a dictionary |
Spacerat
force-pushed
the
feature/assume-s3
branch
from
9e4c696
to
ab3fa8c
Compare
Spacerat
force-pushed
the
feature/assume-s3
branch
from
ab3fa8c
to
5d4f3ca
Compare
Spacerat
force-pushed
the
feature/assume-s3
branch
from
5d4f3ca
to
540fa57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all support for not having S3 enabled. It branches off of #297 (to avoid wasting time with merge conflicts later on).