Merge pull request #344 from pebble/bugfix/kv-table-remove

Fix KV-table row delete regression
pebble · Aug 31, 2016 · 86fb8be · 86fb8be
2 parents e7e7a6e + a46a993
commit 86fb8be
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ide/static/ide/js/KVtable.js b/ide/static/ide/js/KVtable.js
@@ -54,10 +54,10 @@ CloudPebble.KVTable = function(table_elm, options) {
                     .attr('placeholder', key ? null : opts.value_placeholder)),
             $('<td>').append(
                 $('<button>')
-                    .prop('disabled', !key))
+                    .prop('disabled', !key)
                     .text('-')
                     .addClass("btn kv-remove")
-                    .attr('type', 'button')
+                    .attr('type', 'button'))
         ]);
         self.trigger('rowRendered', row);
         return row;

diff --git a/ide/static/ide/js/dependencies.js b/ide/static/ide/js/dependencies.js
@@ -279,6 +279,7 @@ CloudPebble.Dependencies = (function() {
             if (!val) return;
             cache.lookup_module(val).then(function(data) {
                 on_submit(val, data.version ? version_prefix + data.version : null);
+                return null;
             }).catch(function() {
                 on_submit(val, null);
             });