Skip to content

chore: Bump uuid from 1.15.0 to 1.15.1 (#395) #922

chore: Bump uuid from 1.15.0 to 1.15.1 (#395)

chore: Bump uuid from 1.15.0 to 1.15.1 (#395) #922

GitHub Actions / clippy succeeded Feb 27, 2025 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.85.0 (4d91de4e4 2025-02-17)
  • cargo 1.85.0 (d73d2caf9 2024-12-31)
  • clippy 0.1.85 (4d91de4e48 2025-02-17)

Annotations

Check warning on line 99 in fatigue/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
  --> fatigue/src/main.rs:99:47
   |
99 |         output_formatter.update_result_status(&*rx.borrow());
   |                                               ^^^^^^^^^^^^^ help: try: `&rx.borrow()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
   = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 77 in fatigue/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
  --> fatigue/src/main.rs:77:28
   |
77 |     let output_formatter = Arc::new(get_output_formatter());
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `Arc<Box<dyn OutputFormatter>>` is not `Send` and `Sync` as `Box<dyn OutputFormatter>` is neither `Send` nor `Sync`
   = help: if the `Arc` will not used be across threads replace it with an `Rc`
   = help: otherwise make `Box<dyn OutputFormatter>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
   = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 158 in libfatigue/src/context/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
   --> libfatigue/src/context/mod.rs:158:18
    |
158 |             .map(|a| StaticContextTracker::new(a))
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `StaticContextTracker::new`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 67 in libfatigue/src/context/result.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
  --> libfatigue/src/context/result.rs:64:13
   |
64 | /             match &action.internal {
65 | |                 Ok(info) => self.mark_success_action(info, action),
66 | |                 Err(_) => {}
67 | |             }
   | |_____________^ help: try: `if let Ok(info) = &action.internal { self.mark_success_action(info, action) }`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match

Check warning on line 43 in libfatigue/src/context/actions/json.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> libfatigue/src/context/actions/json.rs:43:21
   |
42 |                     let res = serde_json::from_str(raw.as_str())?;
   |                     ---------------------------------------------- unnecessary `let` binding
43 |                     res
   |                     ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
42 ~                     
43 ~                     serde_json::from_str(raw.as_str())?
   |

Check warning on line 98 in libfatigue/src/actions/request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
  --> libfatigue/src/actions/request.rs:91:9
   |
91 | /         match &self.props.response_context_key {
92 | |             Some(key) => {
93 | |                 let body = &resp.json::<Value>().await?;
94 | |                 ctx.items
...  |
97 | |             None => {}
98 | |         };
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
   = note: `#[warn(clippy::single_match)]` on by default
help: try
   |
91 ~         if let Some(key) = &self.props.response_context_key {
92 +             let body = &resp.json::<Value>().await?;
93 +             ctx.items
94 +                 .insert(key.clone(), liquid::model::to_value(&body).unwrap());
95 ~         };
   |

Check warning on line 36 in libfatigue/src/actions/request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::str::Lines<'_>`

warning: useless conversion to the same type: `std::str::Lines<'_>`
  --> libfatigue/src/actions/request.rs:34:43
   |
34 |           let rendered_path_lines: Vec<_> = rendered_path
   |  ___________________________________________^
35 | |             .lines()
36 | |             .into_iter()
   | |________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
   |
34 ~         let rendered_path_lines: Vec<_> = rendered_path
35 +             .lines()
   |